Skip to content

fix NRE during fade when element is destroyed #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kulltero wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix NRE during fade when element is destroyed #104

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e35bfd4
fix NRE during fade when element is destroyed
Kulltero Aug 24, 2026
5f73fbc
check here too
Kulltero Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions CommunityEntity.UI.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1020,6 +1020,9 @@ private void BuildScrollbar(Scrollbar scrollbar, JSON.Object obj, bool vertical)

static IEnumerator FadeCanvasGroup(CanvasGroup group, float to, float duration)
{
if(group == null)
yield break;

float from = group.alpha;
float elapsed = 0f;
while (elapsed < duration)
Expand All @@ -1029,11 +1032,13 @@ static IEnumerator FadeCanvasGroup(CanvasGroup group, float to, float duration)
group.alpha = value;
yield return null;
// another fade changed the value since we set it, abort
if (group.alpha != value)
if (group == null || group.alpha != value)
yield break;
}
group.alpha = to;
}

if(group != null)
group.alpha = to;
}

// sets the transform to a sensible default
private void FitParent(RectTransform transform){
Expand Down