Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@fast/graphics
1.6.0
Automated tests, custom calendar popup for FastDateInput, column-level filtering in FastTable with range support.
Storybook Tests
FastDateInput
<input type="date">with a full React-calendar. Month/year navigation with ChevronLeft/ChevronRight icons, 7-column day grid (Mon–Sun), selected day highlighted with brandmainbackground +contrastText, today highlighted withaction.hover.useEffectwithmousedownlistener on document closes the popup when clicking outside the wrapper.setFocused(false)forced incommitDateso the floating label drops back to center when clearing.:activemoved to Trigger: removed from the wrapper (which contained the popup), added to the Trigger div. Clicking calendar days, arrows, or buttons no longer triggers the press-down transform on the whole component.FastTable
columnFilterableprop: when true, renders a filter input row in<thead>below the header row. Each column gets a text input connected toheader.column.setFilterValue().meta: { filterVariant: 'range' }render two number inputs (Min / Max) instead of a single text input. Values are stored as[min, max]array.inNumberRange: tanstack/react-table's nativeinNumberRangefilter function. UsesresolveFilterValuefor string-to-number parsing, auto-swaps min/max when inverted, and auto-removes when both inputs are empty.filterFn: 'inNumberRange'withmeta: { filterVariant: 'range' }.FastButton — aXe fixes
::beforemoved toStyledWrapper: pseudo-element moved from.Btnto the outer wrapper so.Btnhas no overlapping pseudo-elements. aXe can now resolve color contrast against the singlebackground-coloron.Btn. Addedpointer-events: noneon::beforeto prevent click interception.filter 0.2s easeto.Btn-contenttransition. The default variant usesfilter: invert(1)on hover which now fades smoothly instead of snapping, matching the fluid feel of outlined/text variants.FastTextField / FastTextArea — aXe fixes
aria-label={placeholder}: added to both<input>and<textarea>elements. The floating label (<span class="float-label">) is visual only — aXe requires a programmatic association.aria-labelresolves the "Form label" critical violation without changing the visual design.