skill-authoring: CLOSED PRs can carry landed content via consolidation - #198
Open
firaen22 wants to merge 1 commit into
Open
skill-authoring: CLOSED PRs can carry landed content via consolidation#198firaen22 wants to merge 1 commit into
firaen22 wants to merge 1 commit into
Conversation
The campaign-continuation check's touching-candidate search only queries --state open and --state merged. A maintainer who lands contributions by rebuilding them (no cherry-pick) into a consolidated branch and closing the originals with a disposition comment produces PRs that are neither open nor merged, so the existing query silently drops them from the candidate set even though their content is live on the anchor branch. Observed on F-e-u-e-r/opus-pack itself: PRs F-e-u-e-r#173-181 were each closed individually and landed via consolidated PRs F-e-u-e-r#194-197 (verified by reading each disposition comment and grepping the landed content against upstream main). Add a caveat that CLOSED is not automatically a non-hit — read the disposition comment or diff the PR's changes against the anchor branch before excluding a closed PR from the touching-candidate set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The campaign-continuation check's touching-candidate search queries
--state openand--state mergedonly. A maintainer who lands contributions by rebuilding them (no cherry-pick) into a consolidated branch and closing the originals with a disposition comment produces PRs that are neither open nor merged — so the existing query silently drops them from the candidate set even though their content is live on the anchor branch.Evidence
Observed on this repo itself: PRs #173-181 were each closed individually and landed via consolidated PRs #194-197. Verified independently (not just from the disposition comments) by:
git log --oneline --mergesshowing all 4 triage-batch merge commits reachable frommainmainChange
Adds one caveat to the existing OPEN+MERGED query block in skill-authoring's campaign-continuation-check rule: CLOSED is not automatically a non-hit. Before excluding a closed PR from the touching-candidate set, read its disposition comment or diff its changes against the anchor branch — a closed PR with no disposition comment and no matching content on the anchor branch is the only shape that safely reads as declined.
Test plan
upstream/mainatc2fc127, not from any prior local PR diff