fix: use sans-serif font family on Linux when Twemoji is enabled#134
Open
tyronetheqt wants to merge 1 commit into
Open
fix: use sans-serif font family on Linux when Twemoji is enabled#134tyronetheqt wants to merge 1 commit into
tyronetheqt wants to merge 1 commit into
Conversation
When Twemoji is set as a fontFamilyFallback on Linux with no explicit fontFamily (null), the Flutter engine promotes the first fallback to the primary font. This causes Twemoji to render all text glyphs, resulting in missing characters for most UI text. Fix this by setting fontFamily to "sans-serif" (resolved through fontconfig) on Linux when Twemoji is enabled. On other platforms the existing null behavior is preserved, since their font managers handle fontFamilyFallback correctly. As a related improvement, filter out Android-specific fonts (SystemFont, Roboto) from the fallback fonts list on non-Android platforms. Closes ExteraApp#124
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Twemoji is set as a `fontFamilyFallback` on Linux with no explicit `fontFamily` (null), the Flutter engine promotes the first fallback to the primary font. This causes Twemoji to render all text glyphs, resulting in missing characters for most UI text on Linux.
Fix this by setting `fontFamily` to ``sans-serif`` (resolved through fontconfig) on Linux when Twemoji is enabled. On other platforms the existing null behavior is preserved, since their font managers handle `fontFamilyFallback` correctly.
As a related improvement, Android-specific fonts (SystemFont, Roboto) are filtered out from the fallback fonts list on non-Android platforms to avoid lookup failures.
Closes #124