Skip to content

Ignore third-party OnyxDB read rejections in Sentry - #99819

Open
mukhrr wants to merge 2 commits into
Expensify:mainfrom
mukhrr:fix/98793
Open

Ignore third-party OnyxDB read rejections in Sentry#99819
mukhrr wants to merge 2 commits into
Expensify:mainfrom
mukhrr:fix/98793

Conversation

@mukhrr

@mukhrr mukhrr commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

The Convert Experiments script loaded by web/index.html reads OnyxDB directly and rejects with bare strings such as No data found for key reportActions_undefined. Because the rejection value is a string and not an Error, the event reaches Sentry with no stack frames, so thirdPartyErrorFilterIntegration (which tags by frame origin) cannot tag it.

ignoreErrors matches on the message instead of the stack, so it does catch these. This adds a /No data found for key/ pattern to it, covering the whole family of keys that helper reads, plus a regression test.

No app behaviour changes; this only affects which events are reported to Sentry.

Fixed Issues

$ #98793
PROPOSAL: #98793 (comment)

Tests

  1. Run npx jest tests/unit/setupSentryTest.ts and verify both tests pass.
  2. Open src/setup/telemetry/setupSentry.ts and delete the /No data found for key/ entry from the ignoreErrors array.
  3. Re-run npx jest tests/unit/setupSentryTest.ts and verify the first test now fails, confirming the test actually covers the fix.
  4. Restore the deleted entry and re-run the test, verifying it passes again.
  5. Run the app on web, sign in, and verify no errors appear in the JS console.
  • Verify that no errors appear in the JS console

Offline tests

  1. Sign in on web and load the Inbox.
  2. Turn off your network connection.
  3. Verify the app behaves exactly as it did before this change: the offline indicator appears and navigation still works.
  4. Turn the network back on and verify the app reconnects normally.

The change only controls which events are reported to Sentry, so it touches no network or Onyx read path.

QA Steps

  1. Open https://staging.new.expensify.com in Chrome.
  2. Open DevTools with Cmd+Option+J (macOS) or Ctrl+Shift+J (Windows) and select the Console tab.
  3. Sign up with a brand-new email address.
  4. Complete the onboarding flow through every step until you land on the Inbox.
  5. Verify onboarding behaves exactly as before: each step accepts input, the Continue button advances, and no step is skipped or blocked.
  6. In the Console, verify no red error containing the text No data found for key appears at any point.
  7. Open a chat, send a message, and verify it sends and no new red errors appear in the Console.
  8. Reload the page and verify the app loads back into the Inbox with no red errors in the Console.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

No UI changes, the fix only changes which events are reported to Sentry.

Android: Native

No UI changes.

Android: mWeb Chrome

No UI changes.

iOS: Native

No UI changes.

iOS: mWeb Safari

No UI changes.

MacOS: Chrome / Safari

No UI changes.

The Convert Experiments script loaded by web/index.html reads OnyxDB
directly and rejects with bare strings such as "No data found for key
reportActions_undefined". Those rejections carry no stack frames, so
thirdPartyErrorFilterIntegration cannot tag them. Match them by message
via ignoreErrors instead.
@mukhrr
mukhrr requested review from a team as code owners August 29, 2026 07:25
@melvin-bot
melvin-bot Bot requested review from brunovjk and joekaufmanexpensify and removed request for a team August 29, 2026 07:25
@melvin-bot

melvin-bot Bot commented Aug 29, 2026

Copy link
Copy Markdown

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team August 29, 2026 07:25

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ca44ced4b7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/setup/telemetry/setupSentry.ts Outdated
The unanchored pattern would also drop a thrown Error whose message
happens to contain the same text, on every platform, discarding a real
stack. Match the browser SDK's string-rejection wording instead, which
still covers every key that helper reads.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant