Fix Expensify links in chat that use single quotes - #99808
Draft
deetergp wants to merge 3 commits into
Draft
Conversation
Co-authored-by: Claude <claude@anthropic.com>
Co-authored-by: Claude <claude@anthropic.com>
Co-authored-by: Claude <claude@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The app rewrites Expensify links in chat messages so they point at the environment you are in. The rewrite only matched links written with double quotes. The backend writes single quotes, so the rewrite did nothing. A staging user clicking the link was sent to production.
This rewrites the link in the raw text instead of parsing the HTML. It now handles single quotes, double quotes and no quotes. Parsing and rebuilding the HTML was not an option, because that mangles our custom tags such as
<mention-user />and<emoji>.Two smaller fixes come with it:
new.expensify.com.example.comis no longer rewritten.Fixed Issues
$ #93100
PROPOSAL:
Tests
I verified this change with unit tests only. I did not run the app on staging, so the console box below is unchecked.
Offline tests
The change only rewrites text that is already on screen. Network state does not affect it.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari