[No QA] Docs updates for E/A#98948 report actions on archived workspaces - #99803
Draft
MelvinBot wants to merge 1 commit into
Draft
[No QA] Docs updates for E/A#98948 report actions on archived workspaces#99803MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
Follow-up to #98948. Report actions are now hidden only when the workspace policy is archived or pending delete, not when a report is archived because its submitter was removed. Co-authored-by: Krishna Chaitanya <c3024@users.noreply.github.com>
40 tasks
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://bd2627a3.helpdot.pages.dev ⚡️ Updated articles: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up for #98948, which changed when report state transitions are hidden.
Before that PR, the actions were hidden whenever the report was archived — including when the report was archived only because its submitter was removed from the workspace. After it, they are hidden only when the workspace (policy) itself is archived or pending deletion. Two published articles described the old behavior, so both are updated:
docs/articles/new-expensify/workspaces/Delete-a-Workspace.mdisRetractActionreturnsfalsefor an archived or pending-delete policy, so Retract no longer appears on a deleted workspace's reports. The bullet now covers only reassignment.docs/articles/new-expensify/workspaces/Managing-Workspace-Members.mdAll UI labels in these changes were read from the live app rather than inferred: Remove from workspace, Delete workspace, Retract, Unapprove, Cancel payment, Change workspace, Approve, and Pay.
Fixed Issues
$ #98868
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
Docs-only change — no app code is touched. Review is a content accuracy check against #98948.
Offline tests
N/A — documentation only.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@c3024, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.