Skip to content

[No QA] Docs updates for E/A#98948 report actions on archived workspaces - #99803

Draft
MelvinBot wants to merge 1 commit into
mainfrom
melvin/docs-98948-archived-policy-report-actions
Draft

[No QA] Docs updates for E/A#98948 report actions on archived workspaces#99803
MelvinBot wants to merge 1 commit into
mainfrom
melvin/docs-98948-archived-policy-report-actions

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site follow-up for #98948, which changed when report state transitions are hidden.

Before that PR, the actions were hidden whenever the report was archived — including when the report was archived only because its submitter was removed from the workspace. After it, they are hidden only when the workspace (policy) itself is archived or pending deletion. Two published articles described the old behavior, so both are updated:

docs/articles/new-expensify/workspaces/Delete-a-Workspace.md

  • The bullet "Outstanding expenses and reports can be retracted by the submitter and assigned to another workspace" is now wrong. isRetractAction returns false for an archived or pending-delete policy, so Retract no longer appears on a deleted workspace's reports. The bullet now covers only reassignment.
  • Added a bullet listing every action that disappears after deletion (Submit, Approve, Pay, Unapprove, Cancel payment, Retract, Reopen) and where they disappear from (report header, More menu, report preview).
  • Added the workaround: Change workspace is still available, so moving the report to an active workspace restores its actions.
  • Added an FAQ entry for "Can I still approve or pay a report after I delete a Workspace?", since that is the question this change will generate.

docs/articles/new-expensify/workspaces/Managing-Workspace-Members.md

  • Added a note under "Remove Workspace Members" stating that admins can still Approve and Pay a removed member's Outstanding reports, and that the report preview still shows those buttons. This is the behavior the linked PR restored, and nothing on the help site said so.
  • Corrected Remove from Workspace to Remove from workspace to match the live UI capitalization.

All UI labels in these changes were read from the live app rather than inferred: Remove from workspace, Delete workspace, Retract, Unapprove, Cancel payment, Change workspace, Approve, and Pay.

Fixed Issues

$ #98868

PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".

Docs-only change — no app code is touched. Review is a content accuracy check against #98948.

  • Verify that no errors appear in the JS console

Offline tests

N/A — documentation only.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@c3024, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Follow-up to #98948. Report actions are now hidden only when the workspace policy is archived or pending delete, not when a report is archived because its submitter was removed.

Co-authored-by: Krishna Chaitanya <c3024@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team August 28, 2026 22:06
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Aug 28, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#98948 report actions on archived workspaces [No QA] Docs updates for E/A#98948 report actions on archived workspaces Aug 28, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://bd2627a3.helpdot.pages.dev ⚡️

Updated articles:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants