[No QA] Docs updates for E/A#99433 Require GPS or map entry distance setting - #99801
Draft
MelvinBot wants to merge 1 commit into
Draft
[No QA] Docs updates for E/A#99433 Require GPS or map entry distance setting#99801MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
Adds the new workspace Distance rates setting to the admin article and explains the hidden Manual/Odometer tabs in the member article. Co-authored-by: Alberto Gonzalez-Cela <Gonals@users.noreply.github.com>
40 tasks
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://9c76d594.helpdot.pages.dev ⚡️ Updated articles: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site (HelpDot) follow-up for #99433, which adds the Require GPS or map entry setting to a workspace's Distance rates > Settings page. When it is on, distance expenses on that workspace must come from a mapped route or a GPS-tracked trip, and the Manual and Odometer tabs are hidden. Nothing in
docs/articlesdescribed this behavior, so admins had no documented way to find the setting and members had no explanation for the missing tabs.Two articles are updated:
docs/articles/new-expensify/workspaces/Set-distance-rates.md(admin)## How to require GPS or map entry for distance expensessection with the navigation path to the toggle.## What happens after you enable Require GPS or map entrysection covering the hidden tabs, the block members hit when they select a restricted workspace, the multi-workspace behavior, and the Your space exemption.internalScopeextended for retrieval.<!-- SCREENSHOT: -->suggestion (perdocs/HELP_AUTHORING_GUIDELINES.mdsection 8) — no image committed.docs/articles/new-expensify/reports-and-expenses/Distance-Expenses.md(member)internalScopeextended.Behavior was taken from the merged code, and every UI string was verified against dev NewDot web on the PR branch:
Require GPS or map entry—src/languages/en.ts(distance.error.mapOrGpsDistanceRequired.title)Manual and odometer entry will be disabled.—workspace.distanceRates.requireMapOrGPSDescriptionThis workspace requires either map-based or GPS-tracked distance expenses.—distance.error.mapOrGpsDistanceRequired.descriptiondocs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.mdwere applied: task-based##headings only, no###, exact UI labels in bold, unified web/mobile navigation phrasing, and relative cross-links placed outside numbered steps.One thing to confirm: the FAQ "Why can't I turn off Require GPS or map entry?" references Exclude commutes, which is still beta-gated (
CONST.BETAS.COMMUTER_EXCLUSIONS) and is not documented anywhere on the help site yet. It is the only reason the toggle locks, so leaving it out makes the locked state unexplainable — but say the word and I'll drop that FAQ until commute exclusions ships publicly.Fixed Issues
$ #99433
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Docs-only change — no app code is touched. Reviewing the rendered Markdown in the two articles is sufficient.
Offline tests
N/A — documentation only.
QA Steps
[No QA] — documentation only, no app behavior changes.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A — documentation only.
Android: mWeb Chrome
N/A — documentation only.
iOS: Native
N/A — documentation only.
iOS: mWeb Safari
N/A — documentation only.
MacOS: Chrome / Safari
UI labels verified on dev NewDot web while writing these docs:
Distance rates Settings tab with Require GPS or map entry toggle
Track distance panel with Map, Manual, GPS, Odometer tabs
@Gonals, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.