Docs updates for E/A#94518 Document Approvals lock with Smart Limit cards - #99798
Draft
MelvinBot wants to merge 1 commit into
Draft
Docs updates for E/A#94518 Document Approvals lock with Smart Limit cards#99798MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
Co-authored-by: Shridhar Goel <ShridharGoel@users.noreply.github.com>
43 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up for #94518.
That PR is behavior-neutral on its own — it swaps the client-side derivation of the approvals lock (reading Expensify Card data) for a backend boolean, so the workspace Workflows page no longer needs card data to know the Approvals toggle should be locked. Nothing changes for the member.
Reviewing it surfaced a real gap on the help site: the locked-Approvals behavior itself was never documented.
docs/articles/new-expensify/workspaces/Add-Approvals.mdtells admins how to turn Approvals on, but never says that it can't be turned off while any Expensify Card in the workspace uses a Smart Limit — the exact rule this PR's code enforces. Admins who hit the locked toggle had nowhere to go.This PR adds:
## How to turn off Approvals when Expensify Cards use a Smart Limitsection explaining why the toggle locks, quoting the in-product message verbatim, and giving the steps to unlock it.Why can't I toggle off Approvals?andWhy can't I choose Smart Limit when I issue an Expensify Card?(the reverse dependency, which was also undocumented).UI labels were verified against dev NewDot web rather than taken from the source PR's prose: the toggle title is Approvals (not "Add approvals"), the workspace left-menu items are Workflows and Expensify Card, and the button is Add approval workflow. The quoted lock message matches
workspace.moreFeatures.workflows.disableApprovalPromptinsrc/languages/en.ts.Written against
docs/HELP_AUTHORING_GUIDELINES.md,docs/HELPSITE_NAMING_CONVENTIONS.md, anddocs/TEMPLATE.md: task-based##headings starting with a question word, no new#headings, exact UI labels in bold, relative cross-link placed outside the numbered steps.Fixed Issues
$
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// Please describe what tests you performed that validate your changes worked.
Automated checks Melvin ran on this branch:
npm run spell-changed -- docs/articles/new-expensify/workspaces/Add-Approvals.md— passed (0 issues). This is the docs merge gate.No new files were added, so
./.github/scripts/createDocsRoutes.shis not required.No app code, types, or styles changed, so lint / typecheck / Jest / React Compiler checks do not apply.
Verify that no errors appear in the JS console
Offline tests
N/A — markdown-only change to the help site.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@ShridharGoel, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.