Skip to content

[HOLD Auth] Prevent repeated bank account unlock requests from being sent - #99792

Open
akinwale wants to merge 7 commits into
Expensify:mainfrom
akinwale:task-app-673219-ee
Open

[HOLD Auth] Prevent repeated bank account unlock requests from being sent#99792
akinwale wants to merge 7 commits into
Expensify:mainfrom
akinwale:task-app-673219-ee

Conversation

@akinwale

@akinwale akinwale commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

For locked bank accounts, prevent multiple repeated unlock account requests being sent when the user clicks on the button to Fix or Unlock the bank account.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/673219
PROPOSAL: https://github.com/Expensify/Expensify/issues/673219#issue-5195034188

Tests

Prerequisites

  • Account with a personal or business bank account in a locked state

Test Steps

  1. Launch Expensify.
  2. Log in with an account that has a personal or business locked account.
  3. Under the "Time sensitive" section on the Home screen, click the "Fix" button beside the locked business bank account.
  4. Verify that navigation occurs to the Concierge DM, with a new message is created stating that the request was sent.
  5. Navigate back to the Home page.
  6. Click the "Fix" button for the same bank account again.
  7. Verify that a modal is shown stating that the request has already been sent.
  8. Repeat steps 6 and 7 for the same bank account on the Wallet page and Workspace settings > Workflows > Payments > Payment account.
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  1. Launch Expensify.
  2. Log in with an account that has a personal or business locked account.
  3. Under the "Time sensitive" section on the Home screen, click the "Fix" button beside the locked business bank account.
  4. Verify that navigation occurs to the Concierge DM, with a new message is created stating that the request was sent.
  5. Navigate back to the Home page.
  6. Click the "Fix" button for the same bank account again.
  7. Verify that a modal is shown stating that the request has already been sent.
  8. Repeat steps 6 and 7 for the same bank account on the Wallet page and Workspace settings > Workflows > Payments > Payment account.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-08-28.at.14.37.20.mp4
Screen.Recording.2026-08-28.at.14.38.04.mp4
Screen.Recording.2026-08-28.at.14.40.22.mp4

@akinwale
akinwale requested review from a team as code owners August 28, 2026 21:07
@melvin-bot

melvin-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

@melvin-bot
melvin-bot Bot requested review from Pujan92 and removed request for a team August 28, 2026 21:07
@melvin-bot

melvin-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from garrettmknight and removed request for a team August 28, 2026 21:07
@github-actions

Copy link
Copy Markdown
Contributor

This PR adds a new Onyx.connectWithoutView call, so I've requested a review from the Onyx performance reviewers (@tgolen, @mountiny, @luacmartins) — a review from any one of them is enough. Please add a link in your PR description to the Slack discussion where the @frontend-performance team approved using connectWithoutView here.

Comment thread src/components/SettlementButton/index.tsx Outdated
Comment thread src/pages/home/TimeSensitiveSection/items/UnlockBankAccount.tsx Outdated
Comment thread src/pages/settings/Wallet/WalletPage/index.tsx Outdated
Comment thread src/pages/workspace/workflows/tabs/WorkflowsPaymentsTab.tsx Outdated
Comment thread src/pages/settings/Wallet/WalletPage/index.tsx Outdated
Comment thread src/pages/settings/Wallet/WalletPage/index.tsx Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5c3a1c99a7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +1870 to +1872
if (initiatingBankAccountUnlock?.isLoading && initiatingBankAccountUnlock?.bankAccountIDToUnlock === bankAccountID) {
return;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Track each in-flight bank account independently

When multiple locked accounts are acted on before their requests finish, this singleton guard remembers only the latest ID. For example, pressing A, then B, then A while responses are slow makes the third call see B as bankAccountIDToUnlock, bypass the guard, and enqueue a second unlock request for A. Track in-flight state per bank-account ID so alternating between accounts cannot evade deduplication.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is based on the existing implementation. Implementing per bank account ID would require a major refactor and is not in scope for this PR.

Comment thread src/libs/actions/BankAccounts.ts Outdated
Comment on lines +79 to +82
Onyx.connectWithoutView({
key: ONYXKEYS.INITIATING_BANK_ACCOUNT_UNLOCK,
callback: (value) => (initiatingBankAccountUnlock = value),
});

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Explain the direct Onyx connection

This new Onyx.connectWithoutView read has no comment justifying why the action layer needs a direct subscription. The repository's delegated Onyx guidance explicitly requires each such read to be justified rather than copied as a pattern, so add the rationale next to this connection.

AGENTS.md reference: AGENTS.md:L1-L3

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the call in favour of passing the Onyx value to the method calls.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/ONYXKEYS.ts 100.00% <ø> (ø)
src/libs/BankAccountUtils.ts 89.62% <100.00%> (+0.15%) ⬆️
src/libs/ExportOnyxState/common.ts 80.95% <ø> (ø)
...e/TimeSensitiveSection/items/UnlockBankAccount.tsx 100.00% <100.00%> (ø)
src/libs/actions/BankAccounts.ts 23.07% <0.00%> (-0.16%) ⬇️
.../workspace/workflows/tabs/WorkflowsPaymentsTab.tsx 71.51% <40.00%> (-0.56%) ⬇️
src/components/SettlementButton/index.tsx 74.28% <25.00%> (-0.12%) ⬇️
src/pages/settings/Wallet/WalletPage/index.tsx 0.00% <0.00%> (ø)
... and 43 files with indirect coverage changes

@akinwale

Copy link
Copy Markdown
Contributor Author

This PR adds a new Onyx.connectWithoutView call, so I've requested a review from the Onyx performance reviewers (@tgolen, @mountiny, @luacmartins) — a review from any one of them is enough. Please add a link in your PR description to the Slack discussion where the @frontend-performance team approved using connectWithoutView here.

Sorry about the noise. I removed the Onyx.connectWithoutView call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants