Fix - Owner can not be removed from workspace after transfer ownership - #99790
Open
FitseTLT wants to merge 5 commits into
Open
Fix - Owner can not be removed from workspace after transfer ownership#99790FitseTLT wants to merge 5 commits into
FitseTLT wants to merge 5 commits into
Conversation
melvin-bot
Bot
requested review from
JmillsExpensify and
Pujan92
and removed request for
a team
August 28, 2026 20:36
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d53e985a5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
When an admin transfers workspace ownership to themselves, the client only merges
ownerandownerAccountIDinto the local policy on success. The backend also moves the payer, but the client never refreshes it, sogetReimburserEmailkeeps resolving to the former owner. The member details page hard-blocks removing the payer, so Remove from workspace dead-ends on an acknowledge-only modal until some unrelated refetch happens to correct the policy — which is why it starts working after a cache clear.This refetches the policy when the transfer completes, so the client reads the payer the server already holds instead of re-deriving it. The transfer's
successDataalso reassigns the payer optimistically to close the round-trip gap, but only when no bank account is connected and the outgoing owner is the resolved payer — with a bank account the backend keeps the former owner and rejects the removal, and a separately configured payer must not be touched. Separately, the removal prompt now checksisReimburserbeforeisTechnicalContact, so a member who is both sees the copy for the condition that actually blocked them.Fixed Issues
$ #96681
PROPOSAL: #96681 (comment)
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
2026-08-28.23-13-08.mp4