Fix profile commuter exclusion indicators when distance rates are disabled - #99787
Open
fedirjh wants to merge 2 commits into
Open
Fix profile commuter exclusion indicators when distance rates are disabled#99787fedirjh wants to merge 2 commits into
fedirjh wants to merge 2 commits into
Conversation
fedirjh
marked this pull request as ready for review
August 28, 2026 19:26
melvin-bot
Bot
requested review from
nyomanjyotisa
and removed request for
a team
August 28, 2026 19:26
|
@nyomanjyotisa Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
melvin-bot
Bot
requested review from
flaviadefaria
and removed request for
a team
August 28, 2026 19:26
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This PR centralizes the "active home and office commuter exclusion" rule in the policy selector seam so both Profile and Home derive the same answer from policy state. The commuter exclusion indicator, hint, and Add home address prompt now require
areDistanceRatesEnabled, which hides them as soon as Distance Rates are disabled even if the savedcommuterExclusionsconfiguration remains in Onyx.Fixed Issues
$ #99752
PROPOSAL: #99752 (comment)
Tests
Account > Profileand verify the home address row shows the commuter exclusion indicator and workspace hint.Account > Profileand verify the commuter exclusion indicator and workspace hint are gone.Home > Time sensitiveand verifyAdd home addressis not shown after Distance Rates are disabled.Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
CleanShot.2026-08-28.at.20.10.27.mp4