Canonicalize targets around labels#1598
Conversation
Deploying agentv with
|
| Latest commit: |
60e8c7f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4eb31d41.agentv.pages.dev |
| Branch Preview URL: | https://feat-av-kfik-6-targets.agentv.pages.dev |
|
Follow-up for CI + local OpenAI-compatible dogfood on
|
|
CI follow-up: all checks are now green on . The formerly failing \ job passed in 1m54s: https://github.com/EntityProcess/agentv/actions/runs/28583074773/job/84747840855 |
|
CI follow-up: all checks are now green on https://github.com/EntityProcess/agentv/actions/runs/28583074773/job/84747840855 |
|
Review findings for PR #1598:
CI and the recorded live dogfood evidence look good, but I would not merge until these contract gaps are fixed. |
|
Addressed both review blockers in commit 2326e7d. Changes:
Validation run locally:
Current PR state after push: mergeable, still draft, Cloudflare Pages check in progress. |
2326e7d to
60e8c7f
Compare
|
Follow-up after CI tested the synthetic merge with current main:
Additional local validation after rebase:
CI is running again on the rebased head. I will not mark ready or merge unless it goes green. |
Summary
labelas the AgentV target/comparison name and optional promptfooidas backend/provider metadata.target/targetsobjects andtargets.yamlthrough the promptfoo-shaped object fields (label,id,config,prompts,transform,delay,env) while preserving AgentV extensions.providersaliases and serializes task/eval bundles back to canonicallabel/configtarget YAML.Validation
bun test packages/core/test/evaluation/providers/targets.test.ts packages/core/test/evaluation/providers/targets-file.test.ts packages/core/test/evaluation/validation/targets-validator.test.ts packages/core/test/evaluation/loaders/config-loader.test.ts packages/core/test/evaluation/validation/eval-validator.test.ts packages/core/test/evaluation/validation/eval-file-schema.test.ts packages/sdk/test/eval-authoring.test.ts apps/cli/test/commands/eval/bundle.test.ts apps/cli/test/commands/runs/rerun.test.ts apps/cli/test/eval.integration.test.tsbun --filter @agentv/core generate:schemabun test packages/core/test/evaluation/validation/eval-schema-sync.test.tsbun run typecheckbun run lintbun --filter @agentv/dashboard buildlabeltarget names, optionalidbackend metadata, and nestedconfig; result PASS, 1/1, mean 50%.Private evidence:
agentv-private:evidence/av-kfik-6-targetscommit77085b9.Notes
OpenAI live dogfood reached the provider path but the copied
OPENAI_API_KEYis a dummy, so Gemini is the successful live provider/grader evidence. Broad migration/codemod work remains withav-kfik.15.