Skip to content

feat: fully implement Player#sendFakeBlock #3009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Timongcraft wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat: fully implement Player#sendFakeBlock #3009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bfb1bcc
feat: init fully implementing Player#sendFakeBlock (cherry picked fro…
Timongcraft Aug 15, 2026
75bad75
chore: internalize fake-op setting again
Timongcraft Aug 15, 2026
2adc926
feat: impl for native platforms (tested on fabric dev client)
Timongcraft Aug 16, 2026
1ab67d3
feat: impl for sponge
Timongcraft Aug 17, 2026
0b07f61
chore: refactor bukkit impl relying on paper-specific accesswidener (…
Timongcraft Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions ...11/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/v1_21_11/PaperweightAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import com.sk89q.worldedit.WorldEditException;
import com.sk89q.worldedit.blocks.BaseItem;
import com.sk89q.worldedit.blocks.BaseItemStack;
import com.sk89q.worldedit.blocks.TileEntityBlock;
import com.sk89q.worldedit.bukkit.BukkitAdapter;
import com.sk89q.worldedit.bukkit.adapter.BukkitImplAdapter;
import com.sk89q.worldedit.entity.BaseEntity;
Expand Down Expand Up @@ -82,6 +83,7 @@
import net.minecraft.core.Registry;
import net.minecraft.core.SectionPos;
import net.minecraft.core.component.DataComponentPatch;
import net.minecraft.core.registries.BuiltInRegistries;
import net.minecraft.core.registries.Registries;
import net.minecraft.nbt.ByteArrayTag;
import net.minecraft.nbt.ByteTag;
Expand Down Expand Up @@ -126,6 +128,7 @@
import net.minecraft.world.level.block.Block;
import net.minecraft.world.level.block.Blocks;
import net.minecraft.world.level.block.entity.BlockEntity;
import net.minecraft.world.level.block.entity.BlockEntityType;
import net.minecraft.world.level.block.entity.StructureBlockEntity;
import net.minecraft.world.level.block.state.StateDefinition;
import net.minecraft.world.level.chunk.ChunkAccess;
Expand Down Expand Up @@ -657,6 +660,7 @@ yield new EnumProperty(state.getName(),
return properties;
}

@SuppressWarnings("deprecation") // -Werror
@Override
public void sendFakeNBT(Player player, BlockVector3 pos, LinCompoundTag nbtData) {
var structureBlock = new StructureBlockEntity(
Expand All @@ -670,6 +674,21 @@ public void sendFakeNBT(Player player, BlockVector3 pos, LinCompoundTag nbtData)
));
}

@Override
public void sendFakeNBT(Player player, BlockVector3 pos, TileEntityBlock tileEntityBlock, LinCompoundTag nbtData) {
BlockEntityType<?> nativeBlockEntityType = BuiltInRegistries.BLOCK_ENTITY_TYPE
.getValue(Identifier.parse(tileEntityBlock.getNbtId()));
if (nativeBlockEntityType == null) {
return;
}

((CraftPlayer) player).getHandle().connection.send(new ClientboundBlockEntityDataPacket(
new BlockPos(pos.x(), pos.y(), pos.z()),
nativeBlockEntityType,
(net.minecraft.nbt.CompoundTag) fromNative(nbtData)
));
}

@Override
public void sendFakeOP(Player player) {
((CraftPlayer) player).getHandle().connection.send(new ClientboundEntityEventPacket(
Expand Down
19 changes: 19 additions & 0 deletions ...1.4/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/v1_21_4/PaperweightAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import com.sk89q.worldedit.WorldEditException;
import com.sk89q.worldedit.blocks.BaseItem;
import com.sk89q.worldedit.blocks.BaseItemStack;
import com.sk89q.worldedit.blocks.TileEntityBlock;
import com.sk89q.worldedit.bukkit.BukkitAdapter;
import com.sk89q.worldedit.bukkit.adapter.BukkitImplAdapter;
import com.sk89q.worldedit.entity.BaseEntity;
Expand Down Expand Up @@ -83,6 +84,7 @@
import net.minecraft.core.Registry;
import net.minecraft.core.SectionPos;
import net.minecraft.core.component.DataComponentPatch;
import net.minecraft.core.registries.BuiltInRegistries;
import net.minecraft.core.registries.Registries;
import net.minecraft.nbt.ByteArrayTag;
import net.minecraft.nbt.ByteTag;
Expand Down Expand Up @@ -127,6 +129,7 @@
import net.minecraft.world.level.block.Block;
import net.minecraft.world.level.block.Blocks;
import net.minecraft.world.level.block.entity.BlockEntity;
import net.minecraft.world.level.block.entity.BlockEntityType;
import net.minecraft.world.level.block.entity.StructureBlockEntity;
import net.minecraft.world.level.block.state.StateDefinition;
import net.minecraft.world.level.chunk.ChunkAccess;
Expand Down Expand Up @@ -637,6 +640,7 @@ yield new EnumProperty(state.getName(),
return properties;
}

@SuppressWarnings("deprecation") // -Werror
@Override
public void sendFakeNBT(Player player, BlockVector3 pos, LinCompoundTag nbtData) {
var structureBlock = new StructureBlockEntity(
Expand All @@ -650,6 +654,21 @@ public void sendFakeNBT(Player player, BlockVector3 pos, LinCompoundTag nbtData)
));
}

@Override
public void sendFakeNBT(Player player, BlockVector3 pos, TileEntityBlock tileEntityBlock, LinCompoundTag nbtData) {
BlockEntityType<?> nativeBlockEntityType = BuiltInRegistries.BLOCK_ENTITY_TYPE
.getValue(ResourceLocation.parse(tileEntityBlock.getNbtId()));
if (nativeBlockEntityType == null) {
return;
}

((CraftPlayer) player).getHandle().connection.send(new ClientboundBlockEntityDataPacket(
new BlockPos(pos.x(), pos.y(), pos.z()),
nativeBlockEntityType,
(net.minecraft.nbt.CompoundTag) fromNative(nbtData)
));
}

@Override
public void sendFakeOP(Player player) {
((CraftPlayer) player).getHandle().connection.send(new ClientboundEntityEventPacket(
Expand Down
19 changes: 19 additions & 0 deletions ...1.5/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/v1_21_5/PaperweightAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import com.sk89q.worldedit.WorldEditException;
import com.sk89q.worldedit.blocks.BaseItem;
import com.sk89q.worldedit.blocks.BaseItemStack;
import com.sk89q.worldedit.blocks.TileEntityBlock;
import com.sk89q.worldedit.bukkit.BukkitAdapter;
import com.sk89q.worldedit.bukkit.adapter.BukkitImplAdapter;
import com.sk89q.worldedit.entity.BaseEntity;
Expand Down Expand Up @@ -83,6 +84,7 @@
import net.minecraft.core.Registry;
import net.minecraft.core.SectionPos;
import net.minecraft.core.component.DataComponentPatch;
import net.minecraft.core.registries.BuiltInRegistries;
import net.minecraft.core.registries.Registries;
import net.minecraft.nbt.ByteArrayTag;
import net.minecraft.nbt.ByteTag;
Expand Down Expand Up @@ -127,6 +129,7 @@
import net.minecraft.world.level.block.Block;
import net.minecraft.world.level.block.Blocks;
import net.minecraft.world.level.block.entity.BlockEntity;
import net.minecraft.world.level.block.entity.BlockEntityType;
import net.minecraft.world.level.block.entity.StructureBlockEntity;
import net.minecraft.world.level.block.state.StateDefinition;
import net.minecraft.world.level.chunk.ChunkAccess;
Expand Down Expand Up @@ -635,6 +638,7 @@ yield new EnumProperty(state.getName(),
return properties;
}

@SuppressWarnings("deprecation") // -Werror
@Override
public void sendFakeNBT(Player player, BlockVector3 pos, LinCompoundTag nbtData) {
var structureBlock = new StructureBlockEntity(
Expand All @@ -648,6 +652,21 @@ public void sendFakeNBT(Player player, BlockVector3 pos, LinCompoundTag nbtData)
));
}

@Override
public void sendFakeNBT(Player player, BlockVector3 pos, TileEntityBlock tileEntityBlock, LinCompoundTag nbtData) {
BlockEntityType<?> nativeBlockEntityType = BuiltInRegistries.BLOCK_ENTITY_TYPE
.getValue(ResourceLocation.parse(tileEntityBlock.getNbtId()));
if (nativeBlockEntityType == null) {
return;
}

((CraftPlayer) player).getHandle().connection.send(new ClientboundBlockEntityDataPacket(
new BlockPos(pos.x(), pos.y(), pos.z()),
nativeBlockEntityType,
(net.minecraft.nbt.CompoundTag) fromNative(nbtData)
));
}

@Override
public void sendFakeOP(Player player) {
((CraftPlayer) player).getHandle().connection.send(new ClientboundEntityEventPacket(
Expand Down
19 changes: 19 additions & 0 deletions ...1.6/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/v1_21_6/PaperweightAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import com.sk89q.worldedit.WorldEditException;
import com.sk89q.worldedit.blocks.BaseItem;
import com.sk89q.worldedit.blocks.BaseItemStack;
import com.sk89q.worldedit.blocks.TileEntityBlock;
import com.sk89q.worldedit.bukkit.BukkitAdapter;
import com.sk89q.worldedit.bukkit.adapter.BukkitImplAdapter;
import com.sk89q.worldedit.entity.BaseEntity;
Expand Down Expand Up @@ -83,6 +84,7 @@
import net.minecraft.core.Registry;
import net.minecraft.core.SectionPos;
import net.minecraft.core.component.DataComponentPatch;
import net.minecraft.core.registries.BuiltInRegistries;
import net.minecraft.core.registries.Registries;
import net.minecraft.nbt.ByteArrayTag;
import net.minecraft.nbt.ByteTag;
Expand Down Expand Up @@ -127,6 +129,7 @@
import net.minecraft.world.level.block.Block;
import net.minecraft.world.level.block.Blocks;
import net.minecraft.world.level.block.entity.BlockEntity;
import net.minecraft.world.level.block.entity.BlockEntityType;
import net.minecraft.world.level.block.entity.StructureBlockEntity;
import net.minecraft.world.level.block.state.StateDefinition;
import net.minecraft.world.level.chunk.ChunkAccess;
Expand Down Expand Up @@ -657,6 +660,7 @@ yield new EnumProperty(state.getName(),
return properties;
}

@SuppressWarnings("deprecation") // -Werror
@Override
public void sendFakeNBT(Player player, BlockVector3 pos, LinCompoundTag nbtData) {
var structureBlock = new StructureBlockEntity(
Expand All @@ -670,6 +674,21 @@ public void sendFakeNBT(Player player, BlockVector3 pos, LinCompoundTag nbtData)
));
}

@Override
public void sendFakeNBT(Player player, BlockVector3 pos, TileEntityBlock tileEntityBlock, LinCompoundTag nbtData) {
BlockEntityType<?> nativeBlockEntityType = BuiltInRegistries.BLOCK_ENTITY_TYPE
.getValue(ResourceLocation.parse(tileEntityBlock.getNbtId()));
if (nativeBlockEntityType == null) {
return;
}

((CraftPlayer) player).getHandle().connection.send(new ClientboundBlockEntityDataPacket(
new BlockPos(pos.x(), pos.y(), pos.z()),
nativeBlockEntityType,
(net.minecraft.nbt.CompoundTag) fromNative(nbtData)
));
}

@Override
public void sendFakeOP(Player player) {
((CraftPlayer) player).getHandle().connection.send(new ClientboundEntityEventPacket(
Expand Down
19 changes: 19 additions & 0 deletions ...1.9/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/v1_21_9/PaperweightAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import com.sk89q.worldedit.WorldEditException;
import com.sk89q.worldedit.blocks.BaseItem;
import com.sk89q.worldedit.blocks.BaseItemStack;
import com.sk89q.worldedit.blocks.TileEntityBlock;
import com.sk89q.worldedit.bukkit.BukkitAdapter;
import com.sk89q.worldedit.bukkit.adapter.BukkitImplAdapter;
import com.sk89q.worldedit.entity.BaseEntity;
Expand Down Expand Up @@ -83,6 +84,7 @@
import net.minecraft.core.Registry;
import net.minecraft.core.SectionPos;
import net.minecraft.core.component.DataComponentPatch;
import net.minecraft.core.registries.BuiltInRegistries;
import net.minecraft.core.registries.Registries;
import net.minecraft.nbt.ByteArrayTag;
import net.minecraft.nbt.ByteTag;
Expand Down Expand Up @@ -126,6 +128,7 @@
import net.minecraft.world.level.block.Block;
import net.minecraft.world.level.block.Blocks;
import net.minecraft.world.level.block.entity.BlockEntity;
import net.minecraft.world.level.block.entity.BlockEntityType;
import net.minecraft.world.level.block.entity.StructureBlockEntity;
import net.minecraft.world.level.block.state.StateDefinition;
import net.minecraft.world.level.chunk.ChunkAccess;
Expand Down Expand Up @@ -656,6 +659,7 @@ yield new EnumProperty(state.getName(),
return properties;
}

@SuppressWarnings("deprecation") // -Werror
@Override
public void sendFakeNBT(Player player, BlockVector3 pos, LinCompoundTag nbtData) {
var structureBlock = new StructureBlockEntity(
Expand All @@ -669,6 +673,21 @@ public void sendFakeNBT(Player player, BlockVector3 pos, LinCompoundTag nbtData)
));
}

@Override
public void sendFakeNBT(Player player, BlockVector3 pos, TileEntityBlock tileEntityBlock, LinCompoundTag nbtData) {
BlockEntityType<?> nativeBlockEntityType = BuiltInRegistries.BLOCK_ENTITY_TYPE
.getValue(ResourceLocation.parse(tileEntityBlock.getNbtId()));
if (nativeBlockEntityType == null) {
return;
}

((CraftPlayer) player).getHandle().connection.send(new ClientboundBlockEntityDataPacket(
new BlockPos(pos.x(), pos.y(), pos.z()),
nativeBlockEntityType,
(net.minecraft.nbt.CompoundTag) fromNative(nbtData)
));
}

@Override
public void sendFakeOP(Player player) {
((CraftPlayer) player).getHandle().connection.send(new ClientboundEntityEventPacket(
Expand Down
19 changes: 19 additions & 0 deletions ...-26.1/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/v26_1/PaperweightAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
import com.sk89q.worldedit.WorldEditException;
import com.sk89q.worldedit.blocks.BaseItem;
import com.sk89q.worldedit.blocks.BaseItemStack;
import com.sk89q.worldedit.blocks.TileEntityBlock;
import com.sk89q.worldedit.bukkit.BukkitAdapter;
import com.sk89q.worldedit.bukkit.adapter.BukkitImplAdapter;
import com.sk89q.worldedit.entity.BaseEntity;
Expand Down Expand Up @@ -83,6 +84,7 @@
import net.minecraft.core.Registry;
import net.minecraft.core.SectionPos;
import net.minecraft.core.component.DataComponentPatch;
import net.minecraft.core.registries.BuiltInRegistries;
import net.minecraft.core.registries.Registries;
import net.minecraft.nbt.ByteArrayTag;
import net.minecraft.nbt.ByteTag;
Expand Down Expand Up @@ -126,6 +128,7 @@
import net.minecraft.world.level.block.Block;
import net.minecraft.world.level.block.Blocks;
import net.minecraft.world.level.block.entity.BlockEntity;
import net.minecraft.world.level.block.entity.BlockEntityType;
import net.minecraft.world.level.block.entity.StructureBlockEntity;
import net.minecraft.world.level.block.state.StateDefinition;
import net.minecraft.world.level.chunk.ChunkAccess;
Expand Down Expand Up @@ -674,6 +677,7 @@ yield new EnumProperty(state.getName(),
return properties;
}

@SuppressWarnings("deprecation") // -Werror
@Override
public void sendFakeNBT(Player player, BlockVector3 pos, LinCompoundTag nbtData) {
var structureBlock = new StructureBlockEntity(
Expand All @@ -687,6 +691,21 @@ public void sendFakeNBT(Player player, BlockVector3 pos, LinCompoundTag nbtData)
));
}

@Override
public void sendFakeNBT(Player player, BlockVector3 pos, TileEntityBlock tileEntityBlock, LinCompoundTag nbtData) {
BlockEntityType<?> nativeBlockEntityType = BuiltInRegistries.BLOCK_ENTITY_TYPE
.getValue(Identifier.parse(tileEntityBlock.getNbtId()));
if (nativeBlockEntityType == null) {
return;
}

((CraftPlayer) player).getHandle().connection.send(new ClientboundBlockEntityDataPacket(
new BlockPos(pos.x(), pos.y(), pos.z()),
nativeBlockEntityType,
(net.minecraft.nbt.CompoundTag) fromNative(nbtData)
));
}

@Override
public void sendFakeOP(Player player) {
((CraftPlayer) player).getHandle().connection.send(new ClientboundEntityEventPacket(
Expand Down
19 changes: 19 additions & 0 deletions ...-26.2/src/main/java/com/sk89q/worldedit/bukkit/adapter/impl/v26_2/PaperweightAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
import com.sk89q.worldedit.WorldEditException;
import com.sk89q.worldedit.blocks.BaseItem;
import com.sk89q.worldedit.blocks.BaseItemStack;
import com.sk89q.worldedit.blocks.TileEntityBlock;
import com.sk89q.worldedit.bukkit.BukkitAdapter;
import com.sk89q.worldedit.bukkit.adapter.BukkitImplAdapter;
import com.sk89q.worldedit.entity.BaseEntity;
Expand Down Expand Up @@ -83,6 +84,7 @@
import net.minecraft.core.Registry;
import net.minecraft.core.SectionPos;
import net.minecraft.core.component.DataComponentPatch;
import net.minecraft.core.registries.BuiltInRegistries;
import net.minecraft.core.registries.Registries;
import net.minecraft.nbt.ByteArrayTag;
import net.minecraft.nbt.ByteTag;
Expand Down Expand Up @@ -126,6 +128,7 @@
import net.minecraft.world.level.block.Block;
import net.minecraft.world.level.block.Blocks;
import net.minecraft.world.level.block.entity.BlockEntity;
import net.minecraft.world.level.block.entity.BlockEntityType;
import net.minecraft.world.level.block.entity.StructureBlockEntity;
import net.minecraft.world.level.block.state.StateDefinition;
import net.minecraft.world.level.chunk.ChunkAccess;
Expand Down Expand Up @@ -679,6 +682,7 @@ yield new EnumProperty(state.getName(),
return properties;
}

@SuppressWarnings("deprecation") // -Werror
@Override
public void sendFakeNBT(Player player, BlockVector3 pos, LinCompoundTag nbtData) {
var structureBlock = new StructureBlockEntity(
Expand All @@ -692,6 +696,21 @@ public void sendFakeNBT(Player player, BlockVector3 pos, LinCompoundTag nbtData)
));
}

@Override
public void sendFakeNBT(Player player, BlockVector3 pos, TileEntityBlock tileEntityBlock, LinCompoundTag nbtData) {
BlockEntityType<?> nativeBlockEntityType = BuiltInRegistries.BLOCK_ENTITY_TYPE
.getValue(Identifier.parse(tileEntityBlock.getNbtId()));
if (nativeBlockEntityType == null) {
return;
}

((CraftPlayer) player).getHandle().connection.send(new ClientboundBlockEntityDataPacket(
new BlockPos(pos.x(), pos.y(), pos.z()),
nativeBlockEntityType,
(net.minecraft.nbt.CompoundTag) fromNative(nbtData)
));
}

@Override
public void sendFakeOP(Player player) {
((CraftPlayer) player).getHandle().connection.send(new ClientboundEntityEventPacket(
Expand Down
Loading