Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions skills/reflect/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ Present the full Accepted / Backlog / Route-to-automate-me / Rejected list to th
- Substantive edit (a new section, a new principle, more than ~10 lines): write it out in full, matching the target skill's existing structure and tone, and show the diff before it's considered done.
- Backlog item: describe the concrete script/check/test to write, but don't write it as part of `reflect` itself — that's separate implementation work once the user confirms it's wanted.
- Route-to-`automate-me` item: don't draft it here. Either invoke `automate-me` directly if the user wants it done now, or leave it as a named follow-up in the summary below.
- Before drafting a new edit, check whether the same lesson was already captured and drafted by an earlier `reflect` pass but never landed — a skill-edit commit is subject to the same disposable-branch/unmerged-PR risk as any other fix, and a lesson that only exists on an unmerged branch is not actually in effect. Search the target repo's history for a prior reflect commit touching the same file/section (e.g. `git log --all --grep="reflect" -i -- <file>`) and check whether it's an ancestor of the branch you're landing on (e.g. `git merge-base --is-ancestor <candidate> HEAD`). If a matching unlanded draft exists, prefer adapting/extending it — and note its commit/branch in the summary so a reviewer can consider closing the duplicate — over writing a third divergent copy of the same lesson.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Landed check uses wrong ref

Medium Severity

The new unlanded-draft check treats git merge-base --is-ancestor <candidate> HEAD as proof a prior reflect lesson has landed and is in effect. HEAD is the working-branch tip, not the trunk sibling workflows start from. On a stacked PR, an earlier unmerged reflect commit is already an ancestor of HEAD, so the check can miss the exact disposable-branch failure mode this bullet exists to catch.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit ccfe8e8. Configure here.


### 7. Summarize

Expand Down