PHL: make eqobs-in programmatically reusable (split parse/tactic)#1023
Open
strub wants to merge 1 commit into
Open
PHL: make eqobs-in programmatically reusable (split parse/tactic)#1023strub wants to merge 1 commit into
strub wants to merge 1 commit into
Conversation
Splits the eqobs-in machinery into a parse layer and a tactic layer:
- A new elaborated 'sim_info' record (in EcPhlEqobs) holds resolved
data (Mpv2.t equalities, ts_inv invariant, resolved codegap1
positions), distinct from the parsetree side which is renamed
'sim_info' -> 'psim_info'.
- 'process_eqobs_in{,S,F}' now only elaborate 'psim_info' -> 'sim_info'
and delegate to new tactic functions 't_eqobs_in{,S,F}' that operate
on already-elaborated data. New 'empty_sim_info' helper.
- This exposes a programmatic 't_eqobs_in cm info tc' entry point,
used by ecPhlRwEquiv and ecPhlOutline (which previously had to go
through the parser-facing path).
- ecPhlRwEquiv.t_rewrite_equiv now takes an elaborated 'codepos1'
(callers elaborate via EcTyping.trans_codepos1) instead of 'pcodepos1'.
Behaviour-preserving refactor (uses the existing ts_inv type).
strub
added a commit
that referenced
this pull request
May 31, 2026
… API) into bdep_ecCircuitsRefactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits the eqobs-in machinery into a parse layer and a tactic layer:
data (Mpv2.t equalities, ts_inv invariant, resolved codegap1
positions), distinct from the parsetree side which is renamed
'sim_info' -> 'psim_info'.
and delegate to new tactic functions 't_eqobs_in{,S,F}' that operate
on already-elaborated data. New 'empty_sim_info' helper.
used by ecPhlRwEquiv and ecPhlOutline (which previously had to go
through the parser-facing path).
(callers elaborate via EcTyping.trans_codepos1) instead of 'pcodepos1'.
Behaviour-preserving refactor (uses the existing ts_inv type).