Various fixes for CORDEX model data#3135
Draft
bouweandela wants to merge 12 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## target-grid-cordex-domain #3135 +/- ##
==========================================================
Coverage 96.24% 96.24%
==========================================================
Files 273 278 +5
Lines 16128 16144 +16
==========================================================
+ Hits 15522 15538 +16
Misses 606 606 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
heightcoordinate from variablesnwof modelCOSMO-crCLIM-v1-1as it does not make sense for this variablelong_nameand standard variable names for coordinates for all variables from modelHadREM3-GA7-05because these are non standarduse_standard_grid: trueby default for modelsCOSMO-crCLIM-v1-1,RACMO22E, andRCA4because these models are missing bounds on the lat/lon coordinates. This could alternatively be solved by computing the lat/lon bounds from the rotated lat/lon bounds.aliasfacet and group the datasets in theensemble_statisticspreprocessor function so they work for CORDEX dataCloses #issue_number
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: