Skip to content

Various fixes for CORDEX model data#3135

Draft
bouweandela wants to merge 12 commits into
target-grid-cordex-domainfrom
more-cordex-fixes
Draft

Various fixes for CORDEX model data#3135
bouweandela wants to merge 12 commits into
target-grid-cordex-domainfrom
more-cordex-fixes

Conversation

@bouweandela

@bouweandela bouweandela commented Jun 26, 2026

Copy link
Copy Markdown
Member

Description

  • Remove height coordinate from variable snw of model COSMO-crCLIM-v1-1 as it does not make sense for this variable
  • Use standard long_name and standard variable names for coordinates for all variables from model HadREM3-GA7-05 because these are non standard
  • Set use_standard_grid: true by default for models COSMO-crCLIM-v1-1, RACMO22E, and RCA4 because these models are missing bounds on the lat/lon coordinates. This could alternatively be solved by computing the lat/lon bounds from the rotated lat/lon bounds.
  • Update the list of facets used to create the alias facet and group the datasets in the ensemble_statistics preprocessor function so they work for CORDEX data

Closes #issue_number

Link to documentation:


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@bouweandela bouweandela changed the base branch from main to target-grid-cordex-domain June 26, 2026 15:19
@bouweandela bouweandela added the fix for dataset Related to dataset-specific fix files label Jun 26, 2026
@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.24%. Comparing base (083c723) to head (0704d4e).

Additional details and impacted files
@@                    Coverage Diff                     @@
##           target-grid-cordex-domain    #3135   +/-   ##
==========================================================
  Coverage                      96.24%   96.24%           
==========================================================
  Files                            273      278    +5     
  Lines                          16128    16144   +16     
==========================================================
+ Hits                           15522    15538   +16     
  Misses                           606      606           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bouweandela bouweandela changed the title More cordex fixes Various fixes for CORDEX model data Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix for dataset Related to dataset-specific fix files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant