Add preprocessor t_test#3133
Draft
FranziskaWinterstein wants to merge 23 commits into
Draft
Conversation
…ep ancillary variables attached through arbitrary preprocessor functions
Contributor
Author
|
Currently the processing fails with see also attached main_log_debug.txt |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3133 +/- ##
==========================================
+ Coverage 96.22% 96.24% +0.01%
==========================================
Files 273 273
Lines 16150 16202 +52
==========================================
+ Hits 15541 15593 +52
Misses 609 609 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
This should be fixed now. I also updated the code so it properly works with lazy/non-lazy and masked/non-masked data, and added corresponding tests. Would be great if you can check if it still works as you would expect! Note that I renamed the preprocessor to Still missing:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This new preprocessor function calculates a t-test and adds the resulted p-value as an Ancillary Variable to the model cubes. This p-value can later be used for hatching non-significant values when plotting the bias of model and reference. It is planned to add such in monitor/multi_datasets.py.
Link to documentation:
Closes #3132
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.