Add CORDEX domain target grids for regridding

[ghossh]

Description

Adds support for using standard CORDEX domain names, such as EUR-11, as target_grid values in the regrid preprocessor.

Previously, target_grid: EUR-11 was treated as an MxN grid specification and failed with:

ValueError: Invalid MxN cell specification for grid, got 'EUR-11'.

Closes #3088

Link to documentation:

https://esmvaltool--3096.org.readthedocs.build/projects/ESMValCore/en/3096/recipe/preprocessor.html#regridding-on-a-cordex-domain-grid

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

• 🧪 The new functionality is relevant and scientifically sound
• 🛠 This pull request has a descriptive title and labels
• 🛠 Code is written according to the code quality guidelines
• 🧪 and 🛠 Documentation is available
• 🛠 Unit tests have been added
• 🛠 Changes are backward compatible
• 🛠 The list of authors is up to date
• 🛠 All checks below this pull request were successful

[CLAassistant]

All committers have signed the CLA.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.24%. Comparing base (61c14ed) to head (ab4873f).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3096      +/-   ##
==========================================
+ Coverage   96.22%   96.24%   +0.01%     
==========================================
  Files         273      273              
  Lines       16150    16175      +25     
==========================================
+ Hits        15541    15568      +27     
+ Misses        609      607       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[bouweandela]

Looks like a great start! Could you take a look at the checklist? A few things to do would be

• sign the CLA
• add a unit test
• add documentation

Usually you can find advice on how to go about that in the pull request template, but in case you missed it you can find it here: https://github.com/ESMValGroup/ESMValCore/blob/main/.github/pull_request_template.md

[ghossh]

Hi @bouweandela , Please provide another review. Not sure why the workflow commit is failing!

[ghossh]

Hi @bouweandela , I found that in case of :

  - project: CORDEX
    domain: EUR-11
    dataset: RACMO22E
    driver: CNRM-CERFACS-CNRM-CM5
    ensemble: r1i1p1
    institute: KNMI
    rcm_version: v2

in this line, it's failing due to no having bounds

ESMValCore/esmvalcore/preprocessor/_regrid.py

Line 1017 in ddd67d7

if not np.allclose(coord1.bounds, coord2.bounds):

A possible solution could be like adding this:

        if not coord1.has_bounds() or not coord2.has_bounds():
            return False

what do you think?

[bouweandela]

Not sure why the workflow commit is failing!

Should be fixed by #3104

[bouweandela]

Regarding the no-bounds issue: this seems unrelated to the changes in this pull request, so it would be great if you could open a new issue for this. We can then make a plan for how to solve it there and tackle it in a new pull request.

[bouweandela]

Nice progress @ghossh! I've pasted the checklist back in the pull request description to make it easier for myself to remember what to look for. A few more things to do would be to add a label to the pull request (e.g. preprocessor) and add yourself to the list of authors. Could you please also update the branch so coverage is uploaded again and I can see which lines of code have coverage.

[bouweandela]

Regarding the no-bounds issue: this seems unrelated to the changes in this pull request, so it would be great if you could open a new issue for this. We can then make a plan for how to solve it there and tackle it in a new pull request.

I forgot, but it looks like I did something on this two months ago in 8d24d14