Skip to content

Fix ConcurrentModificationException [1.21.1] #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ninjaguardian wants to merge 1 commit into
base: release/1.21.1
Choose a base branch
from
Open

Fix ConcurrentModificationException [1.21.1] #1215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions common/src/main/java/com/dtteam/dynamictrees/api/registry/AbstractRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,9 +188,14 @@ public final void lock() {
this.locked = true;
this.dump();

// Run all of the on lock runnables and then clear them.
this.onLockRunnables.forEach(Runnable::run);
this.onLockRunnables.clear();
if (onLockRunnables.isEmpty()) {
return;
}

// Copy the onLockRunnables to prevent a ConcurrentModificationException
List<Runnable> current = new ArrayList<>(onLockRunnables);
onLockRunnables.clear();
current.forEach(Runnable::run);
}

/**
Expand Down