chore: Align auth page with CLI icon#18
Merged
Merged
Conversation
doistbot
reviewed
Jun 5, 2026
Member
doistbot
left a comment
There was a problem hiding this comment.
Thanks Amir for updating the auth callback page styling to align with the CLI icon palette and fixing the SVG blend modes 🤗. No issues were flagged.
I also included a few optional follow-up notes in the details below.
Optional follow-up notes (2)
- [P3] src/lib/auth-pages.ts:174: These new palette literals duplicate the fills already hardcoded inside
COMMS_CLI_ICON_SVG, which is how this page ended up drifting from the icon in the first place. Hoist the ink/lavender values into module-level constants and interpolate them into both the SVG string and the page CSS so future palette changes stay aligned. - [P3] src/lib/auth-pages.ts:230: This PR fixes a specific rendering regression by isolating the logo container, but the nearby auth login wiring test still only checks the page copy. Since
src/commands/auth/auth.test.tsalready calls bothoptions.renderSuccess()andoptions.renderError(), add a regression assertion that the generated HTML includes the logo isolation rule (and the matching error-page change) so a future style cleanup doesn't silently bring back the blend-mode color shift.
Contributor
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The auth callback page used teal accents and the inline SVG logo could render too blue because its blend modes interacted with the page backdrop.
What was changed