Eng 1801: query builder column resize lag#1125
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
@coderabbitai full review |
✅ Action performedFull review finished. |
📝 WalkthroughWalkthroughReplaces HTML drag-and-drop column resizing in ChangesPointer Events Column Resizing
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
apps/roam/src/styles/styles.css (1)
39-43: 💤 Low valueConsider adding
!importanttouser-selectfor consistency.The
cursorproperty uses!importantto ensure it overrides element-specific styles, butuser-select: nonedoesn't. If any child element has an explicituser-selectvalue, text selection during resize could still occur.Suggested change
body.roamjs-query-column-resizing, body.roamjs-query-column-resizing * { cursor: ew-resize !important; - user-select: none; + user-select: none !important; }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/roam/src/styles/styles.css` around lines 39 - 43, The user-select property in the body.roamjs-query-column-resizing and body.roamjs-query-column-resizing * selector lacks the !important flag while cursor: ew-resize has it. Add !important to the user-select: none declaration for consistency, ensuring child elements cannot override the selection restriction during column resizing operations.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@apps/roam/src/styles/styles.css`:
- Around line 39-43: The user-select property in the
body.roamjs-query-column-resizing and body.roamjs-query-column-resizing *
selector lacks the !important flag while cursor: ew-resize has it. Add
!important to the user-select: none declaration for consistency, ensuring child
elements cannot override the selection restriction during column resizing
operations.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 104be335-338c-4399-80fd-089acf18f8c9
📒 Files selected for processing (2)
apps/roam/src/components/results-view/ResultsTable.tsxapps/roam/src/styles/styles.css
Summary by CodeRabbit
Bug Fixes