Feature/v2 1#152
Open
Dimowner wants to merge 10 commits into
Open
Conversation
…thods and add regression test for concurrent access
…ronizing access to amplitudesBuffer
- Implement EditDescriptionDialog for adding/editing descriptions directly from the records list. - Update RecordInfoScreen to include a description editor with a dialog for editing. - Modify RecordsDataSource to persist descriptions in the database and audio file metadata. - Enhance UI components to display descriptions and allow interaction for editing.
- Implement a checkbox in the EditDescriptionDialog to allow users to choose whether to embed the description as a COMMENT tag in the audio file. - Update relevant functions and data models to handle the new writeToFile parameter. - Ensure compatibility with formats that do not support comment metadata (e.g., 3GP). - Persist the user's choice for future use.
… reflect character count. Fixed remove tag comment from audio file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address Crashlytics crashes:
Enhance thread-safety in RecordingWaveformBuffer with synchronized methods and add regression test for concurrent access
Enhance thread-safety in MediaRecorderBase and WavRecorderV2 by synchronizing access to amplitudesBuffer
Release media recorder when exception happens on start recording.
Also, this pull request introduces a new feature allowing users to add or edit audio record descriptions (notes) and choose whether to embed these descriptions as metadata in the audio file. It also includes UI improvements for the playback and time panels, and enforces portrait orientation on phones. The most significant changes are grouped below.
Feature: Description Editing and Metadata Embedding
EditDescriptionDialogcomposable for editing a record's description, with a checkbox to control saving the description as a COMMENT tag in the audio file. The dialog adapts based on file format support. (app/src/main/java/com/dimowner/audiorecorder/v2/app/AppComponents.kt)RecordInfoScreen) to use the new dialog and pass the "save to file" flag through, including logic to determine if the file format supports embedding the description. (app/src/main/java/com/dimowner/audiorecorder/v2/app/info/RecordInfoScreen.kt,app/src/main/java/com/dimowner/audiorecorder/v2/app/AppExtensions.kt) [1] [2] [3] [4]IS_SAVE_DESCRIPTION_TO_FILE) and a new constant for the maximum description length (RECORD_DESCRIPTION_MAX_LENGTH). (app/src/main/java/com/dimowner/audiorecorder/v2/DefaultValues.kt,app/src/main/java/com/dimowner/audiorecorder/AppConstantsV2.kt) [1] [2]app/src/androidTest/java/com/dimowner/audiorecorder/v2/data/PrefsV2ImplTest.kt)UI/UX Improvements
app/src/main/java/com/dimowner/audiorecorder/v2/app/components/RecordPlaybackPanel.kt) [1] [2]app/src/main/java/com/dimowner/audiorecorder/v2/app/home/HomeComponents.kt) [1] [2]Device Orientation Handling
app/src/main/java/com/dimowner/audiorecorder/v2/app/HomeActivity.kt) [1] [2]These changes collectively enhance the app's usability by providing users with more control over record metadata, improving the visual design, and ensuring a consistent experience across device types.
Added Korean language support.