fix(dev-k8s): resolve Dockerfile.dev from smartem-decisions, refresh devops skill#218
Open
vredchenko wants to merge 2 commits into
Open
fix(dev-k8s): resolve Dockerfile.dev from smartem-decisions, refresh devops skill#218vredchenko wants to merge 2 commits into
vredchenko wants to merge 2 commits into
Conversation
…devops skill dev-k8s.sh `ensure_local_image` invoked `docker build -f Dockerfile.dev` from $PROJECT_ROOT (smartem-devtools), but Dockerfile.dev lives in smartem-decisions. The build failed with "no such file or directory" on every fresh `up`, leaving operators to discover the workaround themselves. Introduce SMARTEM_DECISIONS_PATH, defaulting to a sibling checkout next to smartem-devtools. Fail fast with a clear message when the file is missing so non-standard layouts can be configured rather than silently broken. Refresh the devops skill in the same change: the script path moved to smartem-devtools, the dev stack now ships an in-cluster Keycloak (with the docker-compose mock kept as the FE-only fallback), and the build command in the skill's container section matches what dev-k8s.sh expects.
vredchenko
added
documentation
github-actions
Bot
added
the
smartem-devtools:claude
Language-less ASCII-art fences (diagrams, terminal output, plain text) were being heuristically tokenised by shiki/rehype-pretty-code, producing stripey per-line backgrounds and broken alignment because the highlighter guessed at keywords that were not there. Set rehype-pretty-code's `defaultLang: 'text'` so any fenced block without an explicit language renders as a uniform monospace block. Source markdown stays unchanged — no doc-side annotations needed. Verified locally against docs/agent/authentication.md: the client_credentials diagram now renders as a single contiguous block. See also #219 (view-source link on docs pages) and #220 (rewrite relative .md links in webui rendering).
github-actions
Bot
added
the
smartem-devtools:webui
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dev-k8s.sh ensure_local_imagerandocker build -f Dockerfile.devfromsmartem-devtools, but the file lives insmartem-decisions. The build failed on every freshupand the workaround (pre-build manually) was undocumented.SMARTEM_DECISIONS_PATH(defaults to the conventional sibling checkout) so the script knows where to findDockerfile.dev, and fails fast with an actionable message if the file is missing.smartem-devtools, in-cluster Keycloak is the primary local auth provider, docker-compose Keycloak is the FE-only fallback, and the container build command matches the image tagdev-k8s.shexpects.Why
Triggered while bringing up the local dev stack to test the FE against a fresh DB dump.
dev-k8s.sh upfailed with:Worked around by building manually first, but the on-disk skill instructions still pointed at the old
smartem-decisions/scripts/k8s/dev-k8s.shpath and made no mention of the in-cluster Keycloak.Test plan
bash -n scripts/k8s/dev-k8s.shpassesSMARTEM_DECISIONS_PATHresolves to the conventional sibling layout underrepos/DiamondLightSource/dev-k8s.sh upreaches "All pods are running" with a freshly built backend imageSMARTEM_DECISIONS_PATHexplicitly