ci: run the .NET binding tests - #517
Merged
Merged
Conversation
Benoît Cortier (CBenoit)
approved these changes
Jul 21, 2026
Benoît Cortier (CBenoit)
left a comment
Member
There was a problem hiding this comment.
LGTM! I pushed some fixes, it seems to be green now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #516. Adds a CI job that builds the native library and runs the .NET binding tests (
Devolutions.Picky.Tests) on Windows — the suite that would have caught the ABI mismatch fixed in #516, but which no workflow was running.What the job does
cargo build --release -p picky-ffi) — matches what ships and avoids debug-only std precondition checks at the FFI boundary.Devolutions.Pickyproject, same asnuget.yml'sbuild-managed).-p:GeneratePackageOnBuild=false), so a stale/mismatched binding fails CI.CopyToOutputDirectory=Never), provisions the fixtures, and runsdotnet test.successgate.Also included
X509Tests.X509Certificate2Conversionlooked up the Subject Key Identifier extension by the friendly-name string"subjectKeyIdentifier", which newer .NET runtimes don't match (the canonical name isSubject Key Identifier). Switched to the OID2.5.29.14so the lookup is runtime-independent.Verified locally: 26/26 tests pass.
Follow-ups (not in this PR)
picky-test-data/test_assets.from_raw_partsprecondition (empty slice passed as a null pointer at the FFI boundary); harmless in release but a real latent diplomat-FFI quirk.