test(qa): PPTX boundary guards, flagship deck example, CI install step#416
Open
DemchaAV wants to merge 2 commits into
Open
test(qa): PPTX boundary guards, flagship deck example, CI install step#416DemchaAV wants to merge 2 commits into
DemchaAV wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The PPTX backend's module boundaries had no bytecode-level guards (nothing stopped POI from leaking into the engine or a template, or the PDF backend from growing a PPTX dependency), the
ShapeOutlineexhaustiveness guard only proved the PDF dispatch chains, and the flagship Engine Deck rendered only to PDF — so the new backend had no dev-facing example and the examples CI job could not have resolved it anyway.What
graph-compose-render-pptxjoins the qa test classpath.CrossModuleBoundaryArchTestgains three rules: POI stays a render-backend implementation detail (only the PPTX backend packages — and, for the day render-docx joins this classpath, the DOCX semantic backend — may touch it), the render backends stay template-agnostic, and the PDF backend must not depend on the PPTX artifact (the reverse dependency is by design: the PPTX backend reuses the PDF measurement stack).ShapeOutlineRenderCoverageTestnow renders every permit through all three surfaces on both fixed-layout backends;PptxInlineGeometry.drawOutlinegains the terminalIllegalStateExceptionthat makes the inline PPTX chain discriminating — without it a new outline kind would silently render nothing and the guard would still pass.EngineDeckPptxExamplerenders the exact Engine Deck composition (shared package-privatecompose(...)seam — banner, pipeline, two benchmark pages with tables and native charts) as a geometry-identical .pptx viabuildPptx(); registered inGenerateAllExamples, examples README row extended.graph-compose-render-pptxbefore generating, mirroring the render-docx step; the test-job reactor comment now describes render-pptx as the fixed-layout backend.graph-compose-render-pptxas the fixed-layout, geometry-identical deck backend (clipped regions land as pixel-exact pictures) with its own quick-start dependency row, replacing the stale "semantic export" framing.Verification
CrossModuleBoundaryArchTest6/6,ShapeOutlineRenderCoverageTest4/4 (every permit × three surfaces × two backends).EngineDeckPptxExamplegenerated locally: 4 slides matching the 4 PDF pages; rasterized side-by-side previews of the banner and benchmark pages are visually identical.clean verifyacross core, render-pdf, render-docx, render-pptx, templates, testing, root, bundle, qa, coverage.