feat(api): PPTX convenience trio on DocumentSession#415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Rendering a deck required importing the backend and calling
session.render(new PptxFixedLayoutBackend())by hand — the session's chrome (metadata, watermark, headers/footers) silently did not apply on that path, and there was no PPTX equivalent of thetoPdfBytes/writePdf/buildPdfconvenience surface.What
DocumentSession.toPptxBytes(),writePptx(OutputStream),buildPptx(), andbuildPptx(Path)mirror the PDF trio's contracts: caller-owned streams stay open, the no-arg build uses the builder's default output file, and the session's chrome flows into the deck exactly as it does into the PDF.BackendProviders.fixedLayout("pptx")), so core gains no PPTX dependency; withoutgraph-compose-render-pptxon the classpath the call fails with the existingMissingBackendExceptionnaming the artifact to add.renderBytes/writeFixedLayout/buildFixedLayout), byte-for-byte faithful to the previous PDF behaviour — log keys, null checks, and exception flow unchanged apart from the format placeholder.docs/capabilities.mdoutput table, lifecycle diagram, the empty-document and default-output-file diagnostics, and theMissingBackendExceptionexamples now name both formats.Verification
MissingBackendContractTestalready pins the"pptx"missing-format diagnostics.clean verifyacross core, render-pdf, render-docx, render-pptx, templates, testing, root, bundle, qa, coverage.