update check_run.completed skill to avoid duplicate posts - #202
Open
dembrane-sam-bot wants to merge 1 commit into
Open
update check_run.completed skill to avoid duplicate posts#202dembrane-sam-bot wants to merge 1 commit into
dembrane-sam-bot wants to merge 1 commit into
Conversation
dembrane-sam-bot
enabled auto-merge
July 30, 2026 05:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this change?
Updates
src/recipes/software-delivery/skills/github-webhook-events/check-run-completed.mdto instruct Sam to check the Slack thread history (conversations.replies) before posting a passing CI notification. If a success notification for the latest commit has already been posted, Sam should avoid duplicate posts and exit cleanly. It also clarifies that Sam must userespond()instead ofack()to post the success message so that the daemon's silent-exit gate is satisfied.What did Sam notice that led to this?
Sameer reported that Sam posted the duplicate "CI passed successfully" notification twice in thread
1785328582.306859.A deep dive into daemon and tool logs revealed:
check_run.completedwebhook events sequentially (once for each check run in the suite).aba2a133e024) posted the passing notification, but did so usingack()instead ofrespond(), leaving the silent-exit gate open.dd1c20c94a8f).conversations.replieson its own initiative, saw the post by Session 1, wrote a journal entry about avoiding duplicate posts, and exited cleanly without posting.7b680d372306).check-run-completed.md, and blindly posted the duplicate success notification again.Codifying the
conversations.repliescheck and therespond()requirement prevents this entire class of duplicate notifications.Tier?
Tier 1 (freely propose prose edits to recipe skills).
Confidence?
100% confident. The logs show a clear, reproducible race/state collision across deferred sequential webhook deliveries, which is cleanly resolved by making the Slack history double-check a required step in the skill.