fix 500 error on critical product metrics page#14945
Open
valentijnscholten wants to merge 1 commit into
Open
Conversation
…late
critical_product_metrics view renders metrics.html without a form context
variable. Django resolves undefined template vars as empty string, causing
get_filter_groups to crash with AttributeError on str.visible_fields().
Wrapping the filter_snippet include in {% if form %} prevents the crash.
Fixes DefectDojo#14944.
valentijnscholten
changed the title
valentijnscholten
changed the title
rossops
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
critical_product_metricsview rendersmetrics.htmlwithout aformcontext variable""filter_snippet.htmlcalls{% get_filter_groups form %}unconditionally, which crashes withAttributeError: 'str' object has no attribute 'visible_fields'filter_snippet.htmlinclude in{% if form %}in bothmetrics.htmlandmetrics_classic/metrics.html{% if not critical_prods %}); the filter content div just wasn't guardedFixes #14944