OIDC email verified fix - #3598
Merged
Merged
Conversation
wojcik91
marked this pull request as ready for review
August 24, 2026 09:06
moubctez
reviewed
Aug 24, 2026
|
|
||
| // enable corresponding MFA | ||
| match method { | ||
| let mfa_method: MFAMethod = match method { |
Contributor
There was a problem hiding this comment.
Suggested change
| let mfa_method: MFAMethod = match method { | |
| let mfa_method = match method { |
moubctez
previously approved these changes
Aug 24, 2026
moubctez
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check if email address is verified before merging an external account.
This is only done if a given OIDC provider actually provides an email_verified claim, otherwise the behavior is unchanged.
Out of our officially supported providers only Microsoft does not provide the email_verified claim.
Also user lookup by email address is now an exact case-insensitive match. It previously treated the address as a SQL LIKE pattern, so an address containing % or _ could match a different user.
Closes https://github.com/DefGuard/internal/issues/168