fix(api): preserve verification token on resend mail failure - #120
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(api): preserve verification token on resend mail failure#120cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Deesmo <Deesmo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
POST /v1/agent/verify-email/resendrotated an unverified account's stored verification token before confirming email delivery. If Resend/Postmark returned an error or was unavailable, the endpoint still returned the neutral success message while the previous usable verification link was invalidated, leaving pending signup credits locked until a later successful resend.Root cause
sendEmail()returnedfalseon delivery failure, butsendVerificationEmail()discarded that result and always logged success. The resend path updatedverifyToken/verifyTokenExpiryand launched the send without any failure compensation.Fix
Validation
npm run buildnode tests/verify-resend.test.mjs