Introduce provider-based RPKI & multi-source BGP foundations, change-case preflight/post-verification and webhook alerts - #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
backend/app/config.pyand.env.example.backend/app/services/providers/rpki.pysupportingripestat,routinator,local-jsonandautomodes with fallback and provider disagreement diagnostics, and wired it intobackend/app/services/rpki_checker.pyso existing evaluation logic is preserved.backend/app/services/bgp_visibility_service.pyand made it configurable viaBGP_VISIBILITY_PROVIDERSand a generic-HTTP provider template.backend/app/services/alerting.py(optional HMAC signature header) and integrated alert dispatch into watch runs inbackend/app/services/watch_service.py, storing delivery status and error message on the run.backend/app/api/routes_change_cases.py:POST /api/change-cases/{id}/run-preflightandPOST /api/change-cases/{id}/run-post-change-verificationthat run aggregated preflight logic and a simple post-change status mapping respectively.backend/app/core/system_status.py.backend/alembic/versions/0005_providers_and_changecase_workflow.pyto add newchange_casescolumns and alert fields on watch runs.backend/app/models.pyto include ChangeCase workflow fields and watch-run alert fields (note: see Testing/Limitations below).Testing
cd backend && pytest -qand observed failures (37 failed, 65 passed) that identified missing HTTP library usage and some logic issues; these were iteratively fixed.cd backend && pytest -q tests/test_api_smoke.py::test_bgp_visibility_status_mappingwhich passed.cd frontend && npm run buildwhich completed without errors.Notes / Next steps (testing & operational)
0005_providers_and_changecase_workflowmust be applied before using the new Change Case fields: run Alembic upgrade in environments with a populated DB.Usermodel region by mistake in the working tree view; the Alembic migration adds the intendedwatch_runscolumns but please verify theWatchRunSQLAlchemy model mapping matches the migration before applying in production.Codex Task