fix: preserve dotted keys when appending AOT entries - #289
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the patch application logic for appending new array-of-tables (AOT) entries so that dotted-key structure is preserved, preventing mis-association of nested subtables/keys during re-parse.
Changes:
- Added logic to detect when an AOT entry should use dotted keys and to rebuild appended entries accordingly.
- Hooked the new preservation logic into the “append AOT entry after previous entry scope” insertion path.
- Updated a fuzz/regression test case from
test.failsto a normal passingtest.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/patch.ts | Adds helpers to preserve dotted keys for appended AOT entries and applies them during AOT append insertion. |
| src/tests/patch.fuzz.test.ts | Converts a previously-known failing regression case into a passing test. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.