fix: specialist-suite sweep — surface silent node divergences - #5
Draft
Deaththegrim wants to merge 2 commits into
Draft
fix: specialist-suite sweep — surface silent node divergences#5Deaththegrim wants to merge 2 commits into
Deaththegrim wants to merge 2 commits into
Conversation
…output consistency, conditioning + metadata fallbacks)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 5 silent failure modes in the custom node pack:
PromptLibraryMulti cache/output consistency (init.py:784): IS_CHANGED and load_prompts now use the same policy for missing entry ids. Added regression test verifying cache signature changes consistently with output when entries are deleted.
prompt_log.py OSError handling (SKIPPED): Design intent is best-effort logging; warning already includes path and error detail.
style_node conditioning mismatch (style_node.py:123-128): Added warning logging when tensor shape mismatch prevents style conditioning from being applied.
civitai_save model override fallback (civitai_save.py:1415-1420): Improved warning message to explicitly state which model will be used in metadata when override fails to resolve.
civitai_save LoRA chain truncation (civitai_save.py:829): Added warning when model chain walk encounters an unknown node type, so user knows LoRA collection may be incomplete.
_to_latin1_safe type annotation (civitai_save.py:1158-1166): Removed unreachable None check; function correctly declares str→str.
Test results: 497 passed (baseline 496 + 1 new regression test), 6 skipped.