Skip to content

[OTel] Enable NodeJS client side stats tests#7252

Open
mabdinur wants to merge 1 commit into
mainfrom
munir/enable-nodejs-tests-trace-metrics
Open

[OTel] Enable NodeJS client side stats tests#7252
mabdinur wants to merge 1 commit into
mainfrom
munir/enable-nodejs-tests-trace-metrics

Conversation

@mabdinur

@mabdinur mabdinur commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Motivation

NodeJS dd-trace v5.111.0 will ship client-side stats (OTLP trace metrics) support. This PR enables the tests and adds an addition test case to cover and edge case found in development.

Changes

  • manifests/nodejs.yml: Lifts the blanket missing_feature override on test_otlp_trace_metrics.py for NodeJS, gating it behind >=5.111.0. Removes the now-redundant per-test missing_feature annotation for the native /v0.6/stats test (covered by a remaining missing_feature on the sampling test instead). Adds the ref_5_111_0 version anchor.

  • tests/parametric/test_otlp_trace_metrics.py: Adds test_fr08_9_top_level_not_mixed_with_measured — a new FR08 test verifying that a top-level span and a MEASURED child sharing identical aggregation dimensions produce two separate data points (one with datadog.span.top_level=true, one with false) rather than being merged into a single mislabeled bucket.

@mabdinur mabdinur requested review from a team as code owners July 2, 2026 18:03
@mabdinur mabdinur requested review from vpellan and removed request for a team July 2, 2026 18:03
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/nodejs.yml                                                    @DataDog/dd-trace-js
tests/parametric/test_otlp_trace_metrics.py                             @DataDog/system-tests-core @DataDog/apm-sdk-capabilities

@datadog-official

Copy link
Copy Markdown

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 2 Pipeline jobs failed

Testing the test | System Tests (python, prod) / End-to-end #1 / uwsgi-poc 1   View in Datadog   GitHub Actions

🧪 1 Test failed

tests.test_telemetry.Test_Telemetry.test_app_heartbeats_delays[uwsgi-poc] from system_tests_suite   View in Datadog
AssertionError: Heartbeat sent too fast: 1.0936350000000001s. It should be sent every 2s
assert 1.0936350000000001 > 1.5

self = <tests.test_telemetry.Test_Telemetry object at 0x7f8674ea6090>

    @features.telemetry_heart_beat_collected
    def test_app_heartbeats_delays(self):
        """Check for telemetry heartbeat are not sent too fast/slow, regarding DD_TELEMETRY_HEARTBEAT_INTERVAL
        There are a lot of reason for individual heartbeats to be sent too slow/fast, and the subsequent ones
        to be sent too fast/slow so the RFC says that it must not drift. So we will check the average delay
...

Testing the test | all-jobs-are-green   View in Datadog   GitHub Actions

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4b84a81 | Docs | Datadog PR Page | Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants