[OTel] Enable NodeJS client side stats tests#7252
Open
mabdinur wants to merge 1 commit into
Open
Conversation
Contributor
|
|
mhlidd
approved these changes
Jul 2, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
NodeJS dd-trace v5.111.0 will ship client-side stats (OTLP trace metrics) support. This PR enables the tests and adds an addition test case to cover and edge case found in development.
Changes
manifests/nodejs.yml: Lifts the blanketmissing_featureoverride ontest_otlp_trace_metrics.pyfor NodeJS, gating it behind>=5.111.0. Removes the now-redundant per-testmissing_featureannotation for the native/v0.6/statstest (covered by a remainingmissing_featureon the sampling test instead). Adds theref_5_111_0version anchor.tests/parametric/test_otlp_trace_metrics.py: Addstest_fr08_9_top_level_not_mixed_with_measured— a new FR08 test verifying that a top-level span and aMEASUREDchild sharing identical aggregation dimensions produce two separate data points (one withdatadog.span.top_level=true, one withfalse) rather than being merged into a single mislabeled bucket.