Add on-call pages list#670
Draft
platinummonkey wants to merge 1 commit into
Draft
Conversation
|
I can only run on private repositories. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
pup on-call pages listso users can list on-call page records from the CLI. The command wraps the currently usable unstable on-call pages endpoint while the stable v2 collection endpoint remains unavailable for listing.Motivation
Issue #642 documents that
pup on-call pagesonly supportedcreateandget, leaving users without a programmable CLI path to inspect page volume by team or responder. This addresses the CLI-side gap in this repository while keeping the backend stable-endpoint request tracked separately.Changes
on-call pages listsubcommand with--team,--responder, and--page-sizeoptions./api/unstable/on-call/pages, applies team filtering server-side withfilter=team:<handle>, and applies responder filtering client-side againstrelationships.responders.1..=1000to match the unstable endpoint cap.Testing
cargo +stable fmt --checkgit diff --checkcargo +stable test on_call_pages --lockedwas attempted but blocked before compilation because Cargo could not fetch the pinneddatadog-api-clientgit dependency in this sandbox; the GitHub fetch returned 403.Additional Notes
This intentionally does not claim stable pagination or time-window support. The unstable endpoint does not provide working pagination, server-side responder filtering, or in-query time filtering, so those remain backend/API limitations.
Checklist
Related Issues
Related to #642.
PR by Bits - View session in Datadog
Comment @DataDog to request changes