Wire pup CLI generation into the client generation pipeline#651
Open
dd-octo-sts[bot] wants to merge 1 commit into
Open
Wire pup CLI generation into the client generation pipeline#651dd-octo-sts[bot] wants to merge 1 commit into
dd-octo-sts[bot] wants to merge 1 commit into
Conversation
dd-octo-sts
Bot
added
the
changelog/no-changelog
| // On Linux, also perform a read probe so we fail fast when the | ||
| // Secret Service DBus name is unavailable and can fall back to file | ||
| // storage instead of erroring later during auth flows. | ||
| #[cfg(target_os = "linux")] |
Collaborator
There was a problem hiding this comment.
We should probably keep this.
jack-edmonds-dd
requested changes
Jul 17, 2026
dd-octo-sts
Bot
force-pushed
the
datadog-api-spec/generated/6183
branch
from
July 17, 2026 13:44
5646fcb to
e41198f
Compare
platinummonkey
requested changes
Jul 17, 2026
| .delete_credential() | ||
| .map_err(|e| anyhow::anyhow!("keychain probe cleanup failed: {e}"))?; | ||
| } | ||
| // On Linux, also perform a read probe so we fail fast when the |
Collaborator
There was a problem hiding this comment.
this will break linux keyring support
dd-octo-sts
Bot
force-pushed
the
datadog-api-spec/generated/6183
branch
from
July 17, 2026 14:17
e41198f to
3e70ac9
Compare
Member
|
This PR is a WIP for integrating the generation from OpenAPI Specification. It is not in a review ready state yet. |
This was referenced Jul 17, 2026
dd-octo-sts
Bot
force-pushed
the
datadog-api-spec/generated/6183
branch
from
July 20, 2026 08:40
3e70ac9 to
2d0edc0
Compare
|
dd-octo-sts
Bot
force-pushed
the
datadog-api-spec/generated/6183
branch
from
July 20, 2026 12:40
2d0edc0 to
ee9f80e
Compare
rachelyangdog
pushed a commit
to rachelyangdog/pup
that referenced
this pull request
Jul 20, 2026
openapi-transformer will regenerate pup CLI command modules from the OpenAPI spec into src/generated.rs (see DataDog#651, the pilot run for this pipeline). Land the wiring ahead of that so main.rs never needs touching again on future regenerations: mod generated, flatten GeneratedCommand into the Commands enum so generated subcommands appear as top-level peers, and route the arm through main_inner() following the existing per-domain pattern. src/generated.rs here is a placeholder with an empty GeneratedCommand enum, not DataDog#651's actual generated output - DataDog#651 hand-writes a top-level downtime command (list/get/create/cancel) that collides on the subcommand name with the generated Downtime variant it introduces (clap panics at runtime: "command name `downtime` is duplicated"). That collision needs a product decision - retire/merge the hand-written downtime command, or pick a different pilot operation upstream - before any generated variants land. This PR only establishes the scaffold; DataDog#651 becomes a pure additive diff to generated.rs (and new sibling modules) once that decision is made.
dd-octo-sts
Bot
force-pushed
the
datadog-api-spec/generated/6183
branch
3 times, most recently
from
July 22, 2026 14:12
f3711d5 to
82722a2
Compare
dd-octo-sts
Bot
force-pushed
the
datadog-api-spec/generated/6183
branch
from
July 23, 2026 12:36
82722a2 to
6ee222f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See DataDog/datadog-api-spec#6183 Test branch datadog-api-spec/test/ulysse.mavrocordatos/AAWF-1384/wire-pup-generation