Skip to content

fix(flags): avoid Flutter Web intake preflights - #1108

Open
leoromanovsky wants to merge 5 commits into
developfrom
leo.romanovsky/flutter-web-flags-intake
Open

fix(flags): avoid Flutter Web intake preflights#1108
leoromanovsky wants to merge 5 commits into
developfrom
leo.romanovsky/flutter-web-flags-intake

Conversation

@leoromanovsky

Copy link
Copy Markdown
Contributor

Motivation

Flutter Web sends Flags intake requests with custom Datadog headers. Browsers send an OPTIONS preflight, and intake returns HTTP 403. Evaluation and exposure telemetry then fail.

Changes and Decisions

This change matches the browser intake transport. Web requests use text/plain and put public intake metadata in query parameters. Evaluation uploads use newline-delimited JSON with Datadog context on each event. Native request headers and payloads remain unchanged. A Chrome integration test records cross-origin requests and rejects any OPTIONS request.

Validation

Ran the new test in Chrome against the local recording server. The recorder received one POST to flagevaluation and no OPTIONS request.

@datadog-datadog-prod-us1

This comment has been minimized.

@fuzzybinary

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b066e48db2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/datadog_flags/lib/src/evaluation_aggregator.dart Outdated
@leoromanovsky
leoromanovsky marked this pull request as ready for review August 7, 2026 18:59
@leoromanovsky
leoromanovsky requested review from a team as code owners August 7, 2026 18:59
@leoromanovsky
leoromanovsky requested review from typotter and vjfridge and removed request for a team August 7, 2026 18:59
Comment thread packages/datadog_flags/test/evaluation_aggregator_test.dart
Comment thread packages/datadog_flags/lib/src/evaluation_aggregator.dart Outdated
Comment thread packages/datadog_flags/lib/src/evaluation_aggregator.dart Outdated
Comment thread packages/datadog_flags/lib/src/evaluation_aggregator.dart Outdated
Comment thread packages/datadog_flags/lib/src/intake_platform.dart Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants