fix(flags): avoid Flutter Web intake preflights - #1108
Open
leoromanovsky wants to merge 5 commits into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
Member
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b066e48db2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
leoromanovsky
marked this pull request as ready for review
August 7, 2026 18:59
leoromanovsky
requested review from
typotter and
vjfridge
and removed request for
a team
August 7, 2026 18:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Flutter Web sends Flags intake requests with custom Datadog headers. Browsers send an OPTIONS preflight, and intake returns HTTP 403. Evaluation and exposure telemetry then fail.
Changes and Decisions
This change matches the browser intake transport. Web requests use text/plain and put public intake metadata in query parameters. Evaluation uploads use newline-delimited JSON with Datadog context on each event. Native request headers and payloads remain unchanged. A Chrome integration test records cross-origin requests and rejects any OPTIONS request.
Validation
Ran the new test in Chrome against the local recording server. The recorder received one POST to flagevaluation and no OPTIONS request.