🐛 Report CDN bundles as CDN SDK setup - #4934
Conversation
Simplify the build environment configuration and make each build target define its setup and optional values explicitly.
Bundles Sizes Evolution
|
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 88a12db | Docs | Datadog PR Page | Give us feedback! |
|
having additional assertions in |
|
🤖 Added explicit npm and CDN telemetry setup assertions; this will be included in the next push. |
| webpackBase({ | ||
| entry: `${sandboxPath}/react-app/main.tsx`, | ||
| plugins: [new HtmlWebpackPlugin({ publicPath: '/react-app/' })], | ||
| mode: 'development', |
There was a problem hiding this comment.
suggestion
it looks like includeWorkerString should be added here as well because otherwise it would cause ReferenceError in createDeflateWorker
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 75d75ad32b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
3b6081e to
88a12db
Compare
Motivation
Telemetry emitted by CDN bundles currently reports
sdk_setup: "npm". This makes it difficult to accurately understand how customers install and use the Browser SDK.CDN bundles should report
sdk_setup: "cdn", while npm builds should continue reportingsdk_setup: "npm".Changes
Test instructions
yarn build:bundle.rg -o 'sdk_setup.{6}' packages/*/bundle/*.js.sdk_setup:"cdn".Checklist