Skip to content

✨ [FFL-2857] Feature Flags tab — team filtering + token revocation (stacked PR 4 of 4) - #4932

Open
kellyw1806 wants to merge 1 commit into
mainfrom
kelly.wang/ffl-2857
Open

✨ [FFL-2857] Feature Flags tab — team filtering + token revocation (stacked PR 4 of 4)#4932
kellyw1806 wants to merge 1 commit into
mainfrom
kelly.wang/ffl-2857

Conversation

@kellyw1806

@kellyw1806 kellyw1806 commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Motivation

Stacked on #4912 (flag overrides). Adds team/creator filtering + per-flag descriptions to the Feature Flags tab, plus production OAuth support and token revocation on disconnect.

Stack (review bottom-up)

PR Base What it adds Status
1 of 4 #4913 · FFL-2597 main OAuth sign-in ✅ merged
2 of 4 #4916 · FFL-2858 ffl-2597 catalog browsing ✅ merged
3 of 4 #4912 · FFL-2596 main flag overrides in review
4 of 4 this · FFL-2857 ffl-2596 team filter + token revocation draft

⚠️ Base is kelly.wang/ffl-2596 (#4912) — merge that first. Kept as a draft until #4912 lands; this then retargets to main and gets a quick rebase.

Changes

  • Team & creator filters (server-side): "My feature flags" → created_by=<uuid>; "My teams" → tags=team:<handle>. Identity (user UUID + team handles) comes from /api/v2/current_user + /api/v2/team?filter[me]=true. "My teams" is a checkbox dropdown showing an "N selected" summary.
  • Per-flag description in each row (catalog description attribute), with a "Show more" expander that only appears when the text is actually clamped.
  • Production OAuth: per-site client id (getClientId — staging vs prod); site picker trimmed to US1 + Staging.
  • Token revocation on disconnect (RFC 7009 /oauth2/v1/revoke — revokes the refresh token, clears local tokens either way).
  • Scope-retry: falls back to the required scopes if the OAuth client isn't granted the optional teams_read (via invalid_scope redirect or an authorize page-load failure).

DEMO

Note, we can now choose between datadoghq.com and staging. There are also filters for My Feature Flags and My Teams. Descriptions are fetched as well.

Screen.Recording.2026-08-10.at.1.26.56.PM.mov

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change
  • Added e2e/integration tests for this change
  • Updated documentation and/or relevant AGENTS.md file

@datadog-datadog-us1-prod

datadog-datadog-us1-prod Bot commented Aug 6, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 80.30%
Overall Coverage: 77.25% (+0.04%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c960f4a | Docs | Datadog PR Page | Give us feedback!

@kellyw1806
kellyw1806 force-pushed the kelly.wang/ffl-2596 branch 5 times, most recently from c88291e to 2a98437 Compare August 7, 2026 16:44
@kellyw1806
kellyw1806 force-pushed the kelly.wang/ffl-2857 branch from 4c49f6e to 16b1216 Compare August 7, 2026 16:58
@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 7, 2026

Copy link
Copy Markdown

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 180.44 KiB 180.44 KiB 0 B 0.00%
Rum Profiler 8.43 KiB 8.43 KiB 0 B 0.00%
Rum Recorder 21.12 KiB 21.12 KiB 0 B 0.00%
Logs 57.04 KiB 57.04 KiB 0 B 0.00%
Rum Salesforce N/A 138.47 KiB N/A N/A N/A
Rum Slim 138.47 KiB 138.47 KiB 0 B 0.00%
Worker 22.96 KiB 22.96 KiB 0 B 0.00%
Rum Shopify N/A 200.02 KiB N/A N/A N/A
Rum-shopify Profiler N/A 8.43 KiB N/A N/A N/A
Rum-shopify Recorder N/A 3.72 KiB N/A N/A N/A

@kellyw1806
kellyw1806 force-pushed the kelly.wang/ffl-2596 branch from 2a98437 to da1a176 Compare August 7, 2026 17:26
Base automatically changed from kelly.wang/ffl-2596 to main August 7, 2026 19:14
@kellyw1806
kellyw1806 force-pushed the kelly.wang/ffl-2857 branch from 16b1216 to e4698ab Compare August 10, 2026 15:00
Filter the flag catalog by owning team (teams_read scope + flag identity),
and revoke the OAuth grant at Datadog on disconnect rather than only clearing
local tokens.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@kellyw1806
kellyw1806 force-pushed the kelly.wang/ffl-2857 branch from e4698ab to c960f4a Compare August 10, 2026 17:25
@kellyw1806
kellyw1806 marked this pull request as ready for review August 10, 2026 17:29
@kellyw1806
kellyw1806 requested a review from a team as a code owner August 10, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant