Skip to content

vitest migration - #4720

Draft
BenoitZugmeyer wants to merge 2 commits into
mainfrom
benoit/vitest-wip
Draft

vitest migration#4720
BenoitZugmeyer wants to merge 2 commits into
mainfrom
benoit/vitest-wip

Conversation

@BenoitZugmeyer

Copy link
Copy Markdown
Member

Motivation

Changes

Test instructions

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.
  • Updated documentation and/or relevant AGENTS.md file

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jun 3, 2026

Copy link
Copy Markdown

Pipelines  Tests

Unblock PR with BitsAI

⚠️ Warnings

🚦 7 Pipeline jobs failed

DataDog/browser-sdk | unit   View in Datadog   GitLab

🧪 19 Tests failed

instrumentOnError should call original error handler from Chrome Headless 149.0.0.0 (Linux 0.0.0)   View in Datadog
Error: <spyOn> : onerror has already been spied upon
Usage: spyOn(<object>, <methodName>)
Error: <spyOn> : onerror has already been spied upon
Usage: spyOn(<object>, <methodName>)
    at <Jasmine>
    at spyViaInstrumentOnError (/go/src/github.com/DataDog/browser-sdk/packages/browser-core/src/domain/error/trackRuntimeError.spec.ts:55:24 <- /tmp/_karma_webpack_473264/commons.js:376647:28)
    at UserContext.<anonymous> (/go/src/github.com/DataDog/browser-sdk/packages/browser-core/src/domain/error/trackRuntimeError.spec.ts:73:11 <- /tmp/_karma_webpack_473264/commons.js:376663:15)
    at <Jasmine>
instrumentOnError should handle direct onerror calls when 5th argument (errorObj) is not of type Error should handle objects from Chrome Headless 149.0.0.0 (Linux 0.0.0)   View in Datadog
Error: <spyOn> : onerror has already been spied upon
Usage: spyOn(<object>, <methodName>)
Error: <spyOn> : onerror has already been spied upon
Usage: spyOn(<object>, <methodName>)
    at <Jasmine>
    at spyViaInstrumentOnError (/go/src/github.com/DataDog/browser-sdk/packages/browser-core/src/domain/error/trackRuntimeError.spec.ts:55:24 <- /tmp/_karma_webpack_473264/commons.js:376647:28)
    at UserContext.<anonymous> (/go/src/github.com/DataDog/browser-sdk/packages/browser-core/src/domain/error/trackRuntimeError.spec.ts:262:27 <- /tmp/_karma_webpack_473264/commons.js:376807:35)
    at <Jasmine>
View all failed tests

DataDog/browser-sdk | build-and-lint   View in Datadog   GitLab

DataDog/browser-sdk | check-licenses   View in Datadog   GitLab

View all 7 failed jobs.

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 66.67%
Overall Coverage: 77.17% (-0.04%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ad7994b | Docs | Datadog PR Page | Give us feedback!

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Jun 3, 2026

Copy link
Copy Markdown

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 172.75 KiB 172.75 KiB 0 B 0.00%
Rum Profiler 8.22 KiB 8.22 KiB 0 B 0.00%
Rum Recorder 21.14 KiB 21.14 KiB 0 B 0.00%
Logs 54.44 KiB 54.44 KiB 0 B 0.00%
Rum Slim 130.27 KiB 130.27 KiB 0 B 0.00%
Worker 22.96 KiB 22.96 KiB 0 B 0.00%

@BenoitZugmeyer
BenoitZugmeyer force-pushed the benoit/vitest-wip branch 2 times, most recently from 8c610b2 to 8467818 Compare June 3, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant