Upgrade miniwdl to 1.15.0 and refresh WDL unit test skip lists (#5377) - #5567
Open
annagiroti wants to merge 1 commit into
Open
Upgrade miniwdl to 1.15.0 and refresh WDL unit test skip lists (#5377)#5567annagiroti wants to merge 1 commit into
annagiroti wants to merge 1 commit into
Conversation
miniwdl 1.15.0 adds parsing support for WDL 1.2 `hints` sections, unblocking several previously-skipped conformance unit tests and letting most nested-input tests run. Removes 30 entries across the WDL 1.1 and 1.2 unsupported-test lists that now pass, and updates the remaining entries' comments to reflect their current (rather than pre-upgrade) failure reasons.
adamnovak
reviewed
Aug 18, 2026
adamnovak
left a comment
Member
There was a problem hiding this comment.
This looks OK, but I think for the return codes ones we might be removing information that's still maybe accurate.
I think the CI failed due to the code not type checking against the new MiniWDL, so you might need to fix that.
Comment on lines
+65
to
+66
| "single_return_code_task", # Workflow did not return the correct return code! Got: 1. Expected: 0. | ||
| "all_return_codes_task", # Workflow did not return the correct return code! Got: 42. Expected: 0. |
Member
There was a problem hiding this comment.
Has MiniWDL 1.15 learned about return_codes? I think the Got: codes are probably right for these and it's the expected codes that are wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
miniwdl 1.15.0 adds parsing support for WDL 1.2
hintssections, unblocking several previously-skipped conformance unit tests and letting most nested-input tests run. Removes 30 entries across the WDL 1.1 and 1.2 unsupported-test lists that now pass, and updates the remaining entries' comments to reflect their current (rather than pre-upgrade) failure reasons.Addresses #5377
Changelog Entry
To be copied to the draft changelog by merger:
Reviewer Checklist
issues/XXXX-fix-the-thingin the Toil repo, or from an external repo.camelCasethat want to be insnake_case.docs/running/{cliOptions,cwl,wdl}.rstMerger Checklist