Skip to content

Upgrade miniwdl to 1.15.0 and refresh WDL unit test skip lists (#5377) - #5567

Open
annagiroti wants to merge 1 commit into
masterfrom
issues/5377-wdl12-allow-nested-inputs
Open

Upgrade miniwdl to 1.15.0 and refresh WDL unit test skip lists (#5377)#5567
annagiroti wants to merge 1 commit into
masterfrom
issues/5377-wdl12-allow-nested-inputs

Conversation

@annagiroti

Copy link
Copy Markdown
Collaborator

miniwdl 1.15.0 adds parsing support for WDL 1.2 hints sections, unblocking several previously-skipped conformance unit tests and letting most nested-input tests run. Removes 30 entries across the WDL 1.1 and 1.2 unsupported-test lists that now pass, and updates the remaining entries' comments to reflect their current (rather than pre-upgrade) failure reasons.

Addresses #5377

Changelog Entry

To be copied to the draft changelog by merger:

  • PR submitter writes their recommendation for a changelog entry here

Reviewer Checklist

  • Make sure it is coming from issues/XXXX-fix-the-thing in the Toil repo, or from an external repo.
    • If it is coming from an external repo, make sure to pull it in for CI with:
      contrib/admin/test-pr otheruser theirbranchname issues/XXXX-fix-the-thing
      
    • If there is no associated issue, create one.
  • Read through the code changes. Make sure that it doesn't have:
    • Addition of trailing whitespace.
    • New variable or member names in camelCase that want to be in snake_case.
    • New functions without type hints.
    • New functions or classes without informative docstrings.
    • Changes to semantics not reflected in the relevant docstrings.
    • New or changed command line options for Toil workflows that are not reflected in docs/running/{cliOptions,cwl,wdl}.rst
    • New features without tests.
  • Comment on the lines of code where problems exist with a review comment. You can shift-click the line numbers in the diff to select multiple lines.
  • Finish the review with an overall description of your opinion.

Merger Checklist

  • Make sure the PR passed tests, including the Gitlab tests, for the most recent commit in its branch.
  • Make sure the PR has been reviewed. If not, review it. If it has been reviewed and any requested changes seem to have been addressed, proceed.
  • Merge with the Github "Squash and merge" feature.
    • If there are multiple authors' commits, add Co-authored-by to give credit to all contributing authors.
  • Copy its recommended changelog entry to the Draft Changelog.
  • Append the issue number in parentheses to the changelog entry.

miniwdl 1.15.0 adds parsing support for WDL 1.2 `hints` sections,
unblocking several previously-skipped conformance unit tests and
letting most nested-input tests run. Removes 30 entries across the
WDL 1.1 and 1.2 unsupported-test lists that now pass, and updates the
remaining entries' comments to reflect their current (rather than
pre-upgrade) failure reasons.
@annagiroti
annagiroti requested a review from adamnovak August 18, 2026 07:10

@adamnovak adamnovak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK, but I think for the return codes ones we might be removing information that's still maybe accurate.

I think the CI failed due to the code not type checking against the new MiniWDL, so you might need to fix that.

Comment on lines +65 to +66
"single_return_code_task", # Workflow did not return the correct return code! Got: 1. Expected: 0.
"all_return_codes_task", # Workflow did not return the correct return code! Got: 42. Expected: 0.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has MiniWDL 1.15 learned about return_codes? I think the Got: codes are probably right for these and it's the expected codes that are wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants