Skip to content

Removed $min-contrast-ratio override to improve text contrast - #6080

Open
alexandrevryghem wants to merge 1 commit into
DSpace:mainfrom
alexandrevryghem:improve-default-contrast-configuration_contribute-main
Open

Removed $min-contrast-ratio override to improve text contrast#6080
alexandrevryghem wants to merge 1 commit into
DSpace:mainfrom
alexandrevryghem:improve-default-contrast-configuration_contribute-main

Conversation

@alexandrevryghem

Copy link
Copy Markdown
Member

References

Description

Removed the $min-contrast-ratio bootstrap override to ensure that all themes that use a light primary color still have a high enough text contrast.

Instructions for Reviewers

List of changes in this PR:

  • Removed the $min-contrast-ratio override in _bootstrap_variables.scss & src/themes/dspace/styles/_theme_sass_variable_overrides.scss

Include guidance for how to test or review your PR.

  • Override the primary color in your theme by setting this in src/themes/{theme}/styles/_theme_sass_variable_overrides.scss: $primary: #43515f
  • Verify that without the fix the primary buttons have a failing contrast
    image
  • Run it again on this branch and verify that the primary button's text color is now dark enough to pass the WCAG AA threshold

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR follows all coding best practices based on the Code Conventions Guide
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@alexandrevryghem alexandrevryghem added this to the 11.0 milestone Aug 7, 2026
@alexandrevryghem alexandrevryghem self-assigned this Aug 7, 2026
@alexandrevryghem alexandrevryghem added accessibility quick win Pull request is small in size & should be easy to review and/or merge labels Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accessibility quick win Pull request is small in size & should be easy to review and/or merge

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Discussion: $min-contrast-ratio: 2 default in Bootstrap variables masks contrast failures

1 participant