Sync upstream v11.2.7 (merge conflicts) - #195
Conversation
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…lockscout#14674) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Code Review
This pull request upgrades Blockscout to version 11.2.7, introduces a lightweight transaction preview endpoint, optimizes ENS and metadata preloading using concurrent requests, and implements a pooled HTTP client using Finch to reuse connections. It also adds caching for contract methods and fixes state changes for Eden sponsored transactions. The review feedback highlights critical issues, including unresolved merge conflicts in common-blockscout.env and mix.lock, a bug in HttpClient where Finch.Error is not properly rescued, and several potential runtime crashes due to missing safety checks for nil values or unconfigured environment variables.
d3c3751 to
4f8c2b8
Compare
3d005dd to
e05174d
Compare
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_c58c6bc5-00c5-48d5-b950-420a8f18a9d6) |
e05174d to
07eb854
Compare
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_a9588607-baa6-4066-9ba7-06a0d0e9538b) |
07eb854 to
1425d31
Compare
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_9b37a20c-d99e-4527-a316-89a90d6aa259) |
1425d31 to
87dfa5a
Compare
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_7167e7cd-1b4a-4c4d-8a5a-4fd646969274) |
87dfa5a to
31d8c92
Compare
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_34248327-cebd-4ff2-b17f-e1a1bfb2641d) |
31d8c92 to
a43292f
Compare
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_f64b5c6a-97bb-45b3-a636-bce966f6b9d8) |
a43292f to
15003bc
Compare
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_965d4803-1105-4910-a95d-b1a6c5175c23) |
15003bc to
ae88280
Compare
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_97553bac-5c98-498b-a8a5-0132cf28f7e9) |
…env for upstream v11.2.7 Co-authored-by: Cursor <cursoragent@cursor.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_acad6b6e-2ec3-4ca7-8a70-829fd14bed05) |
Co-authored-by: Cursor <cursoragent@cursor.com>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_9309d0f9-a5e0-4473-8073-f5a022acab6e) |
Upstream Sync - v11.2.7
Auto-merge with upstream
v11.2.7failed. Version/workflow conflicts were auto-resolved,but the following files have code conflicts that need manual resolution:
To resolve:
v11.2.7to trigger Docker buildUpstream release notes
Note
High Risk
Touches core transaction API loading, fee/state-change accounting, proxy-implementation caching, and the HTTP client used on the API critical path. Mis-preloads or pool/cache TTL mistakes can change API payloads or hide proxy data.
Overview
v11.2.7 adds
GET /api/v2/transactions/{hash}/previewfor OG/social embeds (status, timestamp, method, from/to), with opt-inpreload_ens,preload_metadata, anddecode_input.API latency: ENS and metadata preloads now run concurrently through a new Finch-based
HttpClientwith separate short vs proxied pools (MICROSERVICE_HTTP_POOL_SIZE/COUNT). Transaction details load participants in one deduped pass, skip ABIs except ontowhen decoding needs them, batch address tags, and collapse address existence checks into a single query. Contract method lookups and empty verified-non-proxy implementation probes get longer caches (CONTRACT_PROXY_EMPTY_IMPLEMENTATION_DATA_CACHE_TTL).Eden: sponsored txs attribute fees to the fee payer and credit batched call recipients in state changes; interpretation requests include
fee_payerandcalls. Indexer also extracts those addresses for coin-balance tracking.Reviewed by Cursor Bugbot for commit 7a4a0a8. Bugbot is set up for automated code reviews on this repo. Configure here.