Update Named Catalogs Interfaces#109
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the catalog manager interfaces and related implementations to clarify and align creation patterns for named and source-aware models. It ensures that named managers provide both unnamed and named creation methods, while source-aware managers require a source to be specified at creation. The changes also clean up interface inheritance and service registrations to match these patterns.
Catalog Manager API Alignment
INamedCatalogManager<T>andINamedSourceCatalogManager<T>now inherit from the correct base interfaces (ICatalogManager<T>andISourceCatalogManager<T>, respectively), and redundant CRUD method declarations are removed, centralizing them in the base interfaces. [1] [2] [3] [4]INamedCatalogManager<T>) now expose both unnamed (NewAsync(data)) and named (NewAsync(name, data)) creation overloads, while source-aware managers require thesourceparameter (NewAsync(name, source, data)) and do not expose name-only creation. [1] [2] [3]Implementation Updates
NamedCatalogManager<T>andNamedSourceCatalogManager<T>classes are updated to provide the correct overloads forNewAsync, ensuring that only valid creation paths are available for each manager type. [1] [2] [3]DefaultAIProfileManagernow implements the new unnamed creation overload, ensuring consistent initialization logic.Dependency Injection and Registration
INamedCatalogManager<AIProfileTemplate>andINamedCatalogManager<AIDeployment>are removed, so only the appropriate source-aware manager registrations are exposed for source-bound types. [1] [2]These changes clarify the intended usage patterns for catalog manager creation, reduce ambiguity, and ensure that only valid creation methods are exposed for each type of manager.