Skip to content

Update Named Catalogs Interfaces#109

Merged
MikeAlhayek merged 1 commit into
mainfrom
ma/update-named-catalogs
Jul 15, 2026
Merged

Update Named Catalogs Interfaces#109
MikeAlhayek merged 1 commit into
mainfrom
ma/update-named-catalogs

Conversation

@MikeAlhayek

@MikeAlhayek MikeAlhayek commented Jul 15, 2026

Copy link
Copy Markdown
Member

This pull request refactors the catalog manager interfaces and related implementations to clarify and align creation patterns for named and source-aware models. It ensures that named managers provide both unnamed and named creation methods, while source-aware managers require a source to be specified at creation. The changes also clean up interface inheritance and service registrations to match these patterns.

Catalog Manager API Alignment

  • INamedCatalogManager<T> and INamedSourceCatalogManager<T> now inherit from the correct base interfaces (ICatalogManager<T> and ISourceCatalogManager<T>, respectively), and redundant CRUD method declarations are removed, centralizing them in the base interfaces. [1] [2] [3] [4]
  • Named managers (INamedCatalogManager<T>) now expose both unnamed (NewAsync(data)) and named (NewAsync(name, data)) creation overloads, while source-aware managers require the source parameter (NewAsync(name, source, data)) and do not expose name-only creation. [1] [2] [3]

Implementation Updates

  • The NamedCatalogManager<T> and NamedSourceCatalogManager<T> classes are updated to provide the correct overloads for NewAsync, ensuring that only valid creation paths are available for each manager type. [1] [2] [3]
  • The DefaultAIProfileManager now implements the new unnamed creation overload, ensuring consistent initialization logic.

Dependency Injection and Registration

  • Service registrations for INamedCatalogManager<AIProfileTemplate> and INamedCatalogManager<AIDeployment> are removed, so only the appropriate source-aware manager registrations are exposed for source-bound types. [1] [2]

These changes clarify the intended usage patterns for catalog manager creation, reduce ambiguity, and ensure that only valid creation methods are exposed for each type of manager.

@MikeAlhayek
MikeAlhayek merged commit 238a032 into main Jul 15, 2026
10 checks passed
@MikeAlhayek
MikeAlhayek deleted the ma/update-named-catalogs branch July 15, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant