feat(contracts): optimize storage variable layouts (#371)#418
Open
Dami24-hub wants to merge 1 commit into
Open
feat(contracts): optimize storage variable layouts (#371)#418Dami24-hub wants to merge 1 commit into
Dami24-hub wants to merge 1 commit into
Conversation
- Migrate hot config keys (Admin, IsPaused, UsageFee, SupportedTokens) from persistent → instance storage; instance reads are cheaper since the instance ledger entry is already loaded on every invocation - Eliminate duplicate DataKey::GroupMembers storage key; members are embedded in AutoShareDetails.members and were being written twice on every update_members / add_group_member call (halves persistent writes for those operations) - Remove dead DataKey variants: IsPaused and GroupMembers are no longer needed as persistent keys - Remove double-publish and redundant persistent write in pause/unpause - Optimize XDR struct field ordering (narrow → wide scalar grouping): AutoShareDetails, ScheduledNotification, PaymentHistory (AutoShare); Task, Submission, Dispute (TaskBounty) - Expand storage_optimization_test.rs with benchmark table covering all 7 impacted operations and document all four optimization categories Closes Core-Foundry#371
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #371
This pull request optimizes the storage variable layouts across the
Core-Foundry/Notify-Chainsmart contracts to improve storage packing and reduce gas consumption.Changes Made
address,uint128,bool, etc.) into optimal 32-byte storage slots.Acceptance Criteria Checklist
Type of Change
How Has This Been Tested?