[pull] master from DataDog:master#425
Merged
Merged
Conversation
Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com>
…3553) * fix: add missing EntityV3APISpecInterface model and inflector entry The EntityV3APISpec.interface property references EntityV3APISpecInterface as its type, but the model file was never committed. This caused a NameError at deserialization time for any response using that field. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * pre-commit fixes * fix: treat additionalProperties: false as a regular object in child_models The child_models() guard skipping pure-map schemas checked only whether additionalProperties was present in the schema, not whether its value was a real schema object. This caused schemas with additionalProperties: false (e.g. EntityV3APISpecInterface, a oneOf with strict no-extra-props) to be incorrectly skipped — same as a pure Hash<String, T> map — which is why entity_v3_api_spec_interface.rb was never generated. Fix mirrors the pattern already used in type_to_ruby(): only treat additionalProperties as a map type when its value is not in (None, False). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com>
Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com>
Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )