Skip to content

DX: switch to ty as type checker - #333

Draft
dependabot[bot] wants to merge 28 commits into
mainfrom
dependabot/lock-b80f3de47f
Draft

DX: switch to ty as type checker#333
dependabot[bot] wants to merge 28 commits into
mainfrom
dependabot/lock-b80f3de47f

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jul 1, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Bumps the lock group with 11 updates:

| Package | From | To |
| --- | --- | --- |
| [particle](https://github.com/scikit-hep/particle) | `0.26.2` | `1.0.0` |
| [tqdm](https://github.com/tqdm/tqdm) | `4.67.3` | `4.68.3` |
| [ruff](https://github.com/astral-sh/ruff) | `0.15.11` | `0.15.20` |
| [sphinxcontrib-bibtex](https://github.com/mcmtroffaes/sphinxcontrib-bibtex) | `2.6.5` | `2.7.0` |
| [jupyterlab](https://github.com/jupyterlab/jupyterlab) | `4.5.6` | `4.6.1` |
| [jupyterlab-git](https://github.com/jupyterlab/jupyterlab-git) | `0.52.0` | `0.54.0` |
| [jupyterlab-myst](https://github.com/jupyter-book/jupyterlab-myst) | `2.6.0` | `2.7.0` |
| [jupyterlab-quickopen](https://github.com/jupyterlab-contrib/jupyterlab-quickopen) | `2.1.0` | `2.3.0` |
| [mypy](https://github.com/python/mypy) | `1.20.1` | `2.1.0` |
| [pytest](https://github.com/pytest-dev/pytest) | `9.0.3` | `9.1.1` |
| [types-pyyaml](https://github.com/python/typeshed) | `6.0.12.20260408` | `6.0.12.20260518` |


Updates `particle` from 0.26.2 to 1.0.0
- [Release notes](https://github.com/scikit-hep/particle/releases)
- [Changelog](https://github.com/scikit-hep/particle/blob/main/docs/CHANGELOG.md)
- [Commits](scikit-hep/particle@v0.26.2...v1.0.0)

Updates `tqdm` from 4.67.3 to 4.68.3
- [Release notes](https://github.com/tqdm/tqdm/releases)
- [Commits](tqdm/tqdm@v4.67.3...v4.68.3)

Updates `ruff` from 0.15.11 to 0.15.20
- [Release notes](https://github.com/astral-sh/ruff/releases)
- [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md)
- [Commits](astral-sh/ruff@0.15.11...0.15.20)

Updates `sphinxcontrib-bibtex` from 2.6.5 to 2.7.0
- [Changelog](https://github.com/mcmtroffaes/sphinxcontrib-bibtex/blob/develop/CHANGELOG.rst)
- [Commits](mcmtroffaes/sphinxcontrib-bibtex@2.6.5...2.7.0)

Updates `jupyterlab` from 4.5.6 to 4.6.1
- [Release notes](https://github.com/jupyterlab/jupyterlab/releases)
- [Changelog](https://github.com/jupyterlab/jupyterlab/blob/main/RELEASE.md)
- [Commits](https://github.com/jupyterlab/jupyterlab/compare/@jupyterlab/lsp@4.5.6...@jupyterlab/lsp@4.6.1)

Updates `jupyterlab-git` from 0.52.0 to 0.54.0
- [Release notes](https://github.com/jupyterlab/jupyterlab-git/releases)
- [Changelog](https://github.com/jupyterlab/jupyterlab-git/blob/main/CHANGELOG.md)
- [Commits](jupyterlab/jupyterlab-git@v0.52.0...v0.54.0)

Updates `jupyterlab-myst` from 2.6.0 to 2.7.0
- [Release notes](https://github.com/jupyter-book/jupyterlab-myst/releases)
- [Changelog](https://github.com/jupyter-book/jupyterlab-myst/blob/main/CHANGELOG.md)
- [Commits](jupyter-book/jupyterlab-myst@v2.6.0...v2.7.0)

Updates `jupyterlab-quickopen` from 2.1.0 to 2.3.0
- [Release notes](https://github.com/jupyterlab-contrib/jupyterlab-quickopen/releases)
- [Changelog](https://github.com/jupyterlab-contrib/jupyterlab-quickopen/blob/main/CHANGELOG.md)
- [Commits](jupyterlab-contrib/jupyterlab-quickopen@v2.1.0...v2.3.0)

Updates `mypy` from 1.20.1 to 2.1.0
- [Changelog](https://github.com/python/mypy/blob/master/CHANGELOG.md)
- [Commits](python/mypy@v1.20.1...v2.1.0)

Updates `pytest` from 9.0.3 to 9.1.1
- [Release notes](https://github.com/pytest-dev/pytest/releases)
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst)
- [Commits](pytest-dev/pytest@9.0.3...9.1.1)

Updates `types-pyyaml` from 6.0.12.20260408 to 6.0.12.20260518
- [Commits](https://github.com/python/typeshed/commits)
MAINT: bump the lock group with 5 updates

Bumps the lock group with 5 updates:

| Package | From | To |
| --- | --- | --- |
| [https://github.com/ComPWA/policy](https://github.com/ComPWA/policy) | `0.8.9` | `0.8.13` |
| [https://github.com/astral-sh/ruff-pre-commit](https://github.com/astral-sh/ruff-pre-commit) | `v0.15.11` | `0.15.20` |
| [https://github.com/python-jsonschema/check-jsonschema](https://github.com/python-jsonschema/check-jsonschema) | `0.37.1` | `0.37.4` |
| [https://github.com/streetsidesoftware/cspell-cli](https://github.com/streetsidesoftware/cspell-cli) | `v10.0.0` | `10.0.1` |
| [https://github.com/astral-sh/uv-pre-commit](https://github.com/astral-sh/uv-pre-commit) | `0.11.7` | `0.11.26` |


Updates `https://github.com/ComPWA/policy` from 0.8.9 to 0.8.13
- [Release notes](https://github.com/ComPWA/policy/releases)
- [Commits](ComPWA/policy@0.8.9...0.8.13)

Updates `https://github.com/astral-sh/ruff-pre-commit` from v0.15.11 to 0.15.20
- [Release notes](https://github.com/astral-sh/ruff-pre-commit/releases)
- [Commits](astral-sh/ruff-pre-commit@v0.15.11...v0.15.20)

Updates `https://github.com/python-jsonschema/check-jsonschema` from 0.37.1 to 0.37.4
- [Release notes](https://github.com/python-jsonschema/check-jsonschema/releases)
- [Changelog](https://github.com/python-jsonschema/check-jsonschema/blob/main/CHANGELOG.rst)
- [Commits](python-jsonschema/check-jsonschema@0.37.1...0.37.4)

Updates `https://github.com/streetsidesoftware/cspell-cli` from v10.0.0 to 10.0.1
- [Release notes](https://github.com/streetsidesoftware/cspell-cli/releases)
- [Changelog](https://github.com/streetsidesoftware/cspell-cli/blob/main/CHANGELOG.md)
- [Commits](streetsidesoftware/cspell-cli@v10.0.0...v10.0.1)

Updates `https://github.com/astral-sh/uv-pre-commit` from 0.11.7 to 0.11.26
- [Release notes](https://github.com/astral-sh/uv-pre-commit/releases)
- [Commits](astral-sh/uv-pre-commit@0.11.7...0.11.26)

---
updated-dependencies:
- dependency-name: particle
  dependency-version: 1.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: lock
- dependency-name: tqdm
  dependency-version: 4.68.3
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: lock
- dependency-name: ruff
  dependency-version: 0.15.20
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: lock
- dependency-name: sphinxcontrib-bibtex
  dependency-version: 2.7.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: lock
- dependency-name: jupyterlab
  dependency-version: 4.6.1
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: lock
- dependency-name: jupyterlab-git
  dependency-version: 0.54.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: lock
- dependency-name: jupyterlab-myst
  dependency-version: 2.7.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: lock
- dependency-name: jupyterlab-quickopen
  dependency-version: 2.3.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: lock
- dependency-name: mypy
  dependency-version: 2.1.0
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: lock
- dependency-name: pytest
  dependency-version: 9.1.1
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: lock
- dependency-name: types-pyyaml
  dependency-version: 6.0.12.20260518
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: lock
- dependency-name: https://github.com/ComPWA/policy
  dependency-version: 0.8.13
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: lock
- dependency-name: https://github.com/astral-sh/ruff-pre-commit
  dependency-version: 0.15.20
  dependency-type: direct:production
  dependency-group: lock
- dependency-name: https://github.com/python-jsonschema/check-jsonschema
  dependency-version: 0.37.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: lock
- dependency-name: https://github.com/streetsidesoftware/cspell-cli
  dependency-version: 10.0.1
  dependency-type: direct:production
  dependency-group: lock
- dependency-name: https://github.com/astral-sh/uv-pre-commit
  dependency-version: 0.11.26
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: lock
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added the ⬆️ Lock This PR upgrades the lock files label Jul 1, 2026
@redeboer redeboer changed the title MAINT: Bump the "lock" group with 2 updates across multiple ecosystems MAINT: upgrade lock files Jul 2, 2026
@redeboer
redeboer marked this pull request as draft July 2, 2026 08:31
@redeboer
redeboer self-requested a review July 2, 2026 08:32
@redeboer redeboer changed the title MAINT: upgrade lock files FIX: support particle v1.0 Jul 5, 2026
@redeboer redeboer changed the title FIX: support particle v1.0 DX: switch to ty as type checker Jul 5, 2026
@redeboer redeboer added the 🖱️ DX Improvements to the Developer Experience label Jul 5, 2026
@redeboer redeboer added this to the 0.10.9 milestone Jul 6, 2026
@redeboer redeboer removed the ⬆️ Lock This PR upgrades the lock files label Jul 9, 2026
* MAINT: upgrade lock files
@redeboer redeboer added the ⬆️ Lock This PR upgrades the lock files label Jul 17, 2026
Comment thread src/qrules/__init__.py
StateDefinitionInput,
create_initial_facts,
)
from qrules.combinatorics import StateDefinition as StateDefinition

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't that just be

Suggested change
from qrules.combinatorics import StateDefinition as StateDefinition
from qrules.combinatorics import StateDefinition

or is this introducing something like an independent identifier?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also unused

Comment on lines 127 to +145
@@ -110,14 +138,19 @@ def additive_quantum_number_rule(
conservation check. An example would be `.EdgeQuantumNumbers.charge`.
"""

def decorator(rule_class: Any) -> EdgeQNConservationRule:
def decorator(rule_class: _RuleClass) -> _RuleClass:
def new_call(
self: type[EdgeQNConservationRule], # noqa: ARG001
ingoing_edge_qns: list[quantum_number], # type: ignore[valid-type]
outgoing_edge_qns: list[quantum_number], # type: ignore[valid-type]
self: Any, # ruff:ignore[unused-function-argument]
ingoing_edge_qns: list[Any],
outgoing_edge_qns: list[Any],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is Any acceptable here? Shouldn't there be a more specific type?


def check_multistate_g_parity(
isospin: EdgeQN.isospin_magnitude,
isospin: Fraction,

@grayson-helmholz grayson-helmholz Aug 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will have to check this again, but this line goes against the pattern of the other QN's.
This line would then be

        isospin: EdgeIsospinMagnitude,

Comment thread src/qrules/topology.py
Comment on lines +106 to +110
return {
node_id
for node_id in {self.ending_node_id, self.originating_node_id}
if node_id is not None
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be more readable, but does this really help with this PR?

@redeboer
redeboer force-pushed the dependabot/lock-b80f3de47f branch 2 times, most recently from ceb4159 to c5f8a6e Compare August 24, 2026 15:44
@redeboer
redeboer force-pushed the dependabot/lock-b80f3de47f branch from dc3db49 to 2fee050 Compare August 24, 2026 15:46
@redeboer redeboer removed the ⬆️ Lock This PR upgrades the lock files label Aug 24, 2026
@redeboer
redeboer force-pushed the dependabot/lock-b80f3de47f branch from e864dcb to a259b7e Compare August 24, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🖱️ DX Improvements to the Developer Experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants