test(t280): run ontology integration in CI - #71
Conversation
Resolve real-ontology tests through MOOS_ONTOLOGY_PATH, add the private ffs0 checkout job, and pin the D10 widened-governs occupancy case. Validation: MOOS_INTEGRATION=1 go test ./internal/operad; go test ./internal/operad; go vet ./internal/operad authored-by: agent:vscode.hp-laptop.wolfram / session:sam.kernel-proper / t280-a5c-t6
Emit an explicit warning when FFS0_READ_TOKEN is unavailable and run the real-ontology integration suite automatically once the read-only secret is provisioned.
|
A5c credential readback: the first Head Do not read the credential-gated job as integration-green until the warning is absent and the test step executes. Local real-ontology validation passed against 4.0.5: |
There was a problem hiding this comment.
Pull request overview
Adds an explicit “real ontology” integration lane to validate the operad loader and governance/admin-capability assumptions against the private ffs0 ontology, while keeping default go test ./... hermetic.
Changes:
- Centralize integration ontology path resolution via
MOOS_ONTOLOGY_PATHwith a sibling-checkout fallback for local runs. - Add a Go test that pins admin-capability behavior when the WF02 “governs” set widens (agent governance links alongside superadmin).
- Add a dedicated GitHub Actions job that checks out
ffs0(viaFFS0_READ_TOKEN) and runsMOOS_INTEGRATION=1 go test ./....
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/operad/integration_ontology_test.go | Introduces integrationOntologyPath(t) helper to standardize integration ontology resolution. |
| internal/operad/validate_color_gate_test.go | Switches integration test to use integrationOntologyPath(t) instead of ad-hoc sibling probing. |
| internal/operad/member_of_pair_test.go | Switches integration test to use integrationOntologyPath(t) for the real ontology path. |
| internal/operad/loader_port_pairs_test.go | Switches integration test to use integrationOntologyPath(t) for the real ontology path. |
| internal/operad/occupancy_test.go | Adds regression coverage for admin capability when additional WF02 governs links exist. |
| .github/workflows/go-ci.yml | Adds ontology-integration CI job that runs the full suite against ffs0’s ontology.json. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| ontology-integration: | ||
| if: ${{ github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository }} | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Checkout private ontology source | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| repository: Collider-Data-Systems/ffs0 | ||
| path: ffs0 | ||
| token: ${{ secrets.FFS0_READ_TOKEN }} | ||
| sparse-checkout: kb/superset/ontology.json | ||
| sparse-checkout-cone-mode: false | ||
| - uses: actions/setup-go@v5 | ||
| with: | ||
| go-version-file: go.mod | ||
| cache: true | ||
| - name: Test with real ontology | ||
| env: | ||
| MOOS_INTEGRATION: "1" | ||
| MOOS_ONTOLOGY_PATH: ${{ github.workspace }}/ffs0/kb/superset/ontology.json | ||
| run: go test ./... |
Summary
MOOS_ONTOLOGY_PATHthe authoritative real-ontology test input with local sibling checkout fallbackffs0viaFFS0_READ_TOKENand runsMOOS_INTEGRATION=1 go test ./...Validation
MOOS_INTEGRATION=1 MOOS_ONTOLOGY_PATH=<ffs0 ontology> go test ./internal/operadgo test ./internal/operadgo vet ./internal/operadgit diff --checkThe local full
go test ./...reproduced the existing Windows stall and was stopped. The Linux Actions jobs are the full-suite authority. The ontology-integration check is intentionally not a required ruleset check until G9.Coordination: Collider-Data-Systems/ffs0#178 · lane brief Collider-Data-Systems/ffs0#187.
authored-by: agent:vscode.hp-laptop.wolfram / session:sam.kernel-proper / t280-a5c-t6