Add configurable device timeout - #66
Open
scgbckbone wants to merge 1 commit into
Open
Conversation
scgbckbone
force-pushed
the
configurable-device-timeout
branch
from
August 26, 2026 07:52
cce9ec5 to
a6d64c3
Compare
doc-hex
reviewed
Aug 26, 2026
| assert self.dev.get_serial_number_string() == self.serial | ||
|
|
||
| def send_recv(self, msg, expect_errors=False, verbose=0, timeout=3000, encrypt=True): | ||
| def send_recv(self, msg, expect_errors=False, verbose=0, timeout=DEFAULT_TIMEOUT, encrypt=True): |
Contributor
There was a problem hiding this comment.
would be better to have a "unset" value here as the default for the param
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the default
send_recvtimeout to be configured perColdcardDevice, while retaining the existing 3000 ms default. TheCKCC_DEFAULT_TIMEOUTenvironment setting allows process-level configuration for runners that spawn the client in child processes. Needed for our--multiproctest runner i firmwareExplicit per-call timeout values, including
Nonefor no timeout, remain unchanged.